From: Oliver Pitzeier <oliver@linux-kernel.at>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Makefile 'rpm' target on Red Hat (8.0/9)
Date: Sun, 20 Jul 2003 21:40:23 +0200 [thread overview]
Message-ID: <200307201939.h6KJdqxs005419@indianer.linux-kernel.at> (raw)
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Hi folks!
Since Red Hat moved options like '-ta', '-ba' (all the _build_ targets) away from the command 'rpm' to 'rpmbuild', the 'rpm' target is 'broken' (this is true for - at least - 2.4.19 'til 2.4.21-pre5). This is of course not a really big bug, but it also can be easily solved, by simply changing 'rpm -ta' to 'rpmbuild -ta'.
I'm not sure about other distributions like SuSE, Mandrake...
If 'rpmbuild' doesn't work on other rpm-based distributions (like the two above) I would recommend checking for /etc/redhat-release... Patch for Makefile (from kver 2.4.21-pre5) attached.
Best regards,
Oliver
[-- Attachment #2: Makefile.patch --]
[-- Type: application/octet-stream, Size: 1079 bytes --]
--- Makefile.old 2003-07-20 21:14:59.000000000 +0200
+++ Makefile 2003-07-20 21:36:47.000000000 +0200
@@ -13,6 +13,9 @@
else echo sh; fi ; fi)
TOPDIR := $(shell /bin/pwd)
+RPM := $(shell if [ -f /etc/redhat-release ]; then echo rpmbuild; \
+ else echo rpm; fi)
+
HPATH = $(TOPDIR)/include
FINDHPATH = $(HPATH)/asm $(HPATH)/linux $(HPATH)/scsi $(HPATH)/net $(HPATH)/math-emu
@@ -43,7 +46,8 @@
export VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION KERNELRELEASE ARCH \
CONFIG_SHELL TOPDIR HPATH HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC \
- CPP AR NM STRIP OBJCOPY OBJDUMP MAKE MAKEFILES GENKSYMS MODFLAGS PERL
+ CPP AR NM STRIP OBJCOPY OBJDUMP MAKE MAKEFILES GENKSYMS MODFLAGS PERL \
+ RPM
all: do-it-all
@@ -570,5 +574,5 @@
rm $(KERNELPATH) ; \
cd $(TOPDIR) ; \
. scripts/mkversion > .version ; \
- rpm -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
+ $(RPM) -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
rm $(TOPDIR)/../$(KERNELPATH).tar.gz
next reply other threads:[~2003-07-20 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-20 19:40 Oliver Pitzeier [this message]
2003-07-20 19:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307201939.h6KJdqxs005419@indianer.linux-kernel.at \
--to=oliver@linux-kernel.at \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] Makefile '\''rpm'\'' target on Red Hat (8.0/9)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).