linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Oliver Pitzeier <oliver@linux-kernel.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile 'rpm' target on Red Hat (8.0/9)
Date: Sun, 20 Jul 2003 21:58:08 +0200	[thread overview]
Message-ID: <20030720195808.GA2323@mars.ravnborg.org> (raw)
In-Reply-To: <200307201939.h6KJdqxs005419@indianer.linux-kernel.at>

On Sun, Jul 20, 2003 at 09:40:23PM +0200, Oliver Pitzeier wrote:
> If 'rpmbuild' doesn't work on other rpm-based distributions (like the two above) I would recommend checking for /etc/redhat-release... Patch for Makefile (from kver 2.4.21-pre5) attached.

That looks horrible.

In 2.6-test1 the following code is used:
RPM             := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
                        else echo rpm; fi)

I would suggest to do it this way, avoiding a distro specific check.
Also there is no reason to export the RPM variable

	Sam

      reply	other threads:[~2003-07-20 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-20 19:40 Oliver Pitzeier
2003-07-20 19:58 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030720195808.GA2323@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver@linux-kernel.at \
    --subject='Re: [PATCH] Makefile '\''rpm'\'' target on Red Hat (8.0/9)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).