linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jürgen Stohr" <juergen.stohr@gmx.de>
To: andre@linux-ide.org
Cc: linux-kernel@vger.kernel.org
Subject: BUG in pdc202xx_old.c
Date: Sun, 20 Jul 2003 22:06:21 +0200	[thread overview]
Message-ID: <200307202206.21872.juergen.stohr@gmx.de> (raw)

Hi Andre,
in pdc202xx_old.c is a bug that prevents the use of "66 Clocking". The driver 
always falls back to UDMA 33. The reason for this bug is found in function 
"config_chipset_for_dma" when checking if the "other" drive is capable of 
UDMA 66. The follwing patch, which should apply against 2.4.22-pre7, solves 
the problem for me:

--- pdc202xx_old.c.broken       2003-07-20 20:12:39.000000000 +0200
+++ pdc202xx_old.c      2003-07-20 20:18:50.000000000 +0200
@@ -425,7 +425,7 @@
                         * check to make sure drive on same channel
                         * is u66 capable
                         */
-                       if (hwif->drives[!(drive->dn%2)].id) {
+                       if (hwif->drives[!(drive->dn%2)].present) {
                                if (hwif->drives[!(drive->dn%2)].id->dma_ultra 
& 0x0078) {
                                        hwif->OUTB(CLKSPD | mask, 
(hwif->dma_master + 0x11));
                                } else {

regards,
Jürgen


             reply	other threads:[~2003-07-20 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-20 20:06 Jürgen Stohr [this message]
2003-07-20 20:53 ` BUG in pdc202xx_old.c Andre Hedrick
2003-07-20 23:31 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307202206.21872.juergen.stohr@gmx.de \
    --to=juergen.stohr@gmx.de \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).