From: Pavel Machek <pavel@ucw.cz>
To: Peter Osterlund <petero2@telia.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Software suspend testing in 2.6.0-test1
Date: Mon, 21 Jul 2003 23:28:28 +0200 [thread overview]
Message-ID: <20030721212828.GE436@elf.ucw.cz> (raw)
In-Reply-To: <m21xwkvte8.fsf@telia.com>
Hi!
> > But why do you touch PF_FROZEN here? Refrigerator should do that.
> > And wake_up_process should not be needed...
> > If it is in refrigerator, it polls PF_FREEZE...
>
> Note that the old code always called wake_up_process(), which is
> necessary to make the process run one more iteration in refrigerator()
> and relize that it is time to unfreeze.
>
> The patch changes things so that wake_up_process() is NOT called if
> the process is stopped at some other place than in refrigerator().
> This ensures that processes that were stopped before we invoked swsusp
> are still stopped after resume.
Yes, but you still print warning for them. I hopefully killed that.
> I manually clear PF_FREEZE here in an attempt to handle a race
> condition, but I realize I need to understand more of the scheduler
> and signal code before I know for sure if this is necessary and/or
> sufficient.
I do not see the race so I killed that... Here's what I applied.
Pavel
--- /usr/src/tmp/linux/kernel/suspend.c 2003-07-21 22:15:39.000000000 +0200
+++ /usr/src/linux/kernel/suspend.c 2003-07-21 22:11:28.000000000 +0200
@@ -5,7 +5,7 @@
* machine suspend feature using pretty near only high-level routines
*
* Copyright (C) 1998-2001 Gabor Kuti <seasons@fornax.hu>
- * Copyright (C) 1998,2001,2002 Pavel Machek <pavel@suse.cz>
+ * Copyright (C) 1998,2001-2003 Pavel Machek <pavel@suse.cz>
*
* I'd like to thank the following people for their work:
*
@@ -84,7 +84,6 @@
#define ADDRESS2(x) __ADDRESS(__pa(x)) /* Needed for x86-64 where some pages are in memory twice */
/* References to section boundaries */
-extern char _text, _etext, _edata, __bss_start, _end;
extern char __nosave_begin, __nosave_end;
extern int is_head_of_free_region(struct page *);
@@ -164,14 +163,21 @@
* Refrigerator and related stuff
*/
-#define INTERESTING(p) \
- /* We don't want to touch kernel_threads..*/ \
- if (p->flags & PF_IOTHREAD) \
- continue; \
- if (p == current) \
- continue; \
- if (p->state == TASK_ZOMBIE) \
- continue;
+/* 0 = Ignore this process when freezing/thawing, 1 = freeze/thaw this process */
+static inline int interesting_process(struct task_struct *p)
+{
+ if (p->flags & PF_IOTHREAD)
+ return 0;
+ if (p == current)
+ return 0;
+ if ((p->state == TASK_ZOMBIE) || (p->state == TASK_DEAD))
+ return 0;
+ if (p->state == TASK_STOPPED)
+ return 0;
+
+
+ return 1;
+}
#define TIMEOUT (6 * HZ) /* Timeout for stopping processes */
@@ -214,7 +220,8 @@
read_lock(&tasklist_lock);
do_each_thread(g, p) {
unsigned long flags;
- INTERESTING(p);
+ if (!interesting_process(p))
+ continue;
if (p->flags & PF_FROZEN)
continue;
@@ -247,13 +254,14 @@
printk( "Restarting tasks..." );
read_lock(&tasklist_lock);
do_each_thread(g, p) {
- INTERESTING(p);
-
- if (p->flags & PF_FROZEN)
- p->flags &= ~PF_FROZEN;
- else
- printk(KERN_INFO " Strange, %s not stopped\n", p->comm );
- wake_up_process(p);
+ if (!interesting_process(p))
+ continue;
+
+ if (p->flags & PF_FROZEN) {
+ p->flags &= ~PF_FROZEN;
+ wake_up_process(p);
+ } else
+ PRINTK(KERN_ERR " Strange, %s not frozen\n", p->comm );
} while_each_thread(g, p);
read_unlock(&tasklist_lock);
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-07-21 21:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-17 19:46 Software suspend testing in 2.6.0-test1 Peter Osterlund
2003-07-17 20:00 ` Pavel Machek
2003-07-17 20:09 ` Andrew Morton
2003-07-18 9:59 ` Peter Osterlund
2003-07-18 10:24 ` Andrew Morton
2003-07-18 15:22 ` Pavel Machek
2003-07-18 15:55 ` Peter Osterlund
2003-07-18 16:45 ` Andrew Morton
2003-07-18 17:50 ` Pavel Machek
2003-07-18 18:02 ` Patrick Mochel
2003-07-18 18:04 ` Pavel Machek
2003-07-18 21:05 ` Nigel Cunningham
2003-07-18 19:37 ` Andrew Morton
2003-07-18 19:58 ` Peter Osterlund
2003-07-18 20:15 ` Andrew Morton
2003-07-18 22:13 ` Pavel Machek
2003-07-20 0:22 ` Peter Osterlund
2003-07-20 1:01 ` Andrew Morton
2003-07-20 7:45 ` Peter Osterlund
2003-07-18 21:05 ` Nigel Cunningham
2003-07-21 10:00 ` Peter Osterlund
2003-07-21 12:58 ` Pavel Machek
2003-07-21 14:36 ` Peter Osterlund
2003-07-21 21:28 ` Pavel Machek [this message]
2003-07-21 23:46 ` Peter Osterlund
2003-07-22 11:04 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030721212828.GE436@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).