From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: Greg KH <greg@kroah.com>,
kernel list <linux-kernel@vger.kernel.org>,
ole.rohne@cern.ch
Subject: Re: More powermanagment hooks for pci
Date: Tue, 22 Jul 2003 00:12:05 +0200 [thread overview]
Message-ID: <20030721221205.GJ436@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0307211505530.22018-100000@cherise>
Hi!
> > Well, there are likely more drivers that need to quiesce PCI card
> > before resume. (I was wrong, 8390too does *not* need it, radeonfb
> > does). It looks like bug not to have the hook in the first place...
>
> You also didn't credit the original author..
Sorry, Ole was the original author AFAIK.
> > Patrick, can you comment? I was trying to add power_on hook to PCI
> > devices...
>
> I know. I'm thinking of adding power_{off,on} to the core and getting rid
> of the level parameter to the suspend/resume functions (like how I changed
> system devices). That would require an additional hook to the PCI drivers
> so that the call is propogated down to the low-level driver. If that's the
> case, then we should add both to struct pci_driver at once.
Should I modify patch to add both?
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-07-21 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-20 21:29 More powermanagment hooks for pci Pavel Machek
2003-07-21 16:44 ` Greg KH
2003-07-21 21:35 ` Pavel Machek
2003-07-21 22:10 ` Patrick Mochel
2003-07-21 22:12 ` Pavel Machek [this message]
2003-07-22 14:08 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030721221205.GJ436@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=ole.rohne@cern.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).