archive mirror
 help / color / mirror / Atom feed
Subject: Re: [2.6 patch] remove four superfluous BUG's in ReiserFS
Date: Wed, 23 Jul 2003 19:11:35 -0400	[thread overview]
Message-ID: <20030723231135.GA30572@rushmore> (raw)

The patch is a cleanup.  It saves 85 bytes on x86.

size hashes.o*
text    data     bss     dec     hex filename
1333      16       0    1349     545 hashes.o
1248      16       0    1264     4f0

I tested the patch on uniprocessor x86 on filesystems
created with:

yes  "y" | mkreiserfs --format 3.6 -h tea /dev/hdc1
mount -t reiserfs -o defaults,noatime,notail /dev/hdc1 /fs1

The keyed_hash function has 20 less instructions on x86,
but performance improvement is very small.

The default hash is r5, so in the common case, the patch
doesn't do anything except save a few bytes.

Time to run "dbench-2.0 32" 4x and "dbench-2.0 64" 5x.
2.6.0-test1-ac2-r	8560 seconds  (patched)
2.6.0-test1-ac2-t	8615 seconds

The patched version is about .5% faster.

Oddly, the 3rd dbench 32 run on the unpatched version had 2
dbench processes that stayed Sleeping.  Killing the
dbench processes let everything continue.  Because of that
one skewed run,  I deleted the 3rd dbench time from the
"seconds" above for both kernels.

bonnie++-1.03a didn't have much different between
patched and unpatched except for sequential block i/o.

                                 Sequential Output
Kernel                     Size  MB/sec  %CPU   Eff
reiserfs-2.6.0-test1-ac2-r  1024  19.22  75.0 25.63  (patched)
reiserfs-2.6.0-test1-ac2-t  1024  18.18  70.0 25.97

tiobench-0.3.3 improvement with the patch was also small.

Randy Hron

             reply	other threads:[~2003-07-23 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-23 23:11 rwhron [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-07-16 22:57 [2.6 patch] remove four superfluous BUG's in ReiserFS Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030723231135.GA30572@rushmore \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).