Re: [PATCH] Remove module reference counting.

From: "David S. Miller" <davem@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: arjanv@redhat.com, torvalds@transmeta.com, greg@kroah.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove module reference counting.
Date: Fri, 25 Jul 2003 10:47:38 -0700	[thread overview]
Message-ID: <20030725104738.7ffbc118.davem@redhat.com> (raw)
In-Reply-To: <20030725173900.D7DE12C2A9@lists.samba.org>

On Fri, 25 Jul 2003 04:00:18 +1000
Rusty Russell <rusty@rustcorp.com.au> wrote:

> 	If module removal is to be a rare and unusual event, it
> doesn't seem so sensible to go to great lengths in the code to handle
> just that case.  In fact, it's easier to leave the module memory in
> place, and not have the concept of parts of the kernel text (and some
> types of kernel data) vanishing.
> 
> Polite feedback welcome,

I'm ok with this, with one possible enhancement.

How about we make ->cleanup() return a boolean, which if true
causes the caller to do the module_free()?

(Yes I know that doing this will require some more thought
 in order to minimize how large a change it would need to
 be to keep exiting modules working.  It's a seperate discussion.)