From: Adrian Bunk <bunk@fs.tum.de>
To: Harald Welte <laforge@netfilter.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
"David S. Miller" <davem@redhat.com>,
netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [2.4 patch] netfilter Configure.help cleanup
Date: Sat, 26 Jul 2003 12:50:21 +0200 [thread overview]
Message-ID: <20030726105021.GH22218@fs.tum.de> (raw)
In-Reply-To: <20030725205024.GA3244@sunbeam.de.gnumonks.org>
On Fri, Jul 25, 2003 at 10:50:24PM +0200, Harald Welte wrote:
> On Fri, Jul 18, 2003 at 11:06:49AM +1000, Rusty Russell wrote:
> > In message <20030717201304.GL1407@fs.tum.de> you write:
> >
> > > the patch below does the following changes to the netfilter entries in
> > > Configure.help in 2.4.22-pre2:
> > > - order similar to net/ipv4/netfilter/Config.in
> > > - remove useless short descriptions above CONFIG_*
> > > - added CONFIG_IP_NF_MATCH_RECENT entry (stolen from 2.5)
> >
> > Sorry Adrian, I think this is overzealous.
> >
> > Please just add the CONFIG_IP_NF_MATCH_RECENT entry. Remember,
> > "stable" means "boring". 8)
>
> I will submit the RECENT entry to davem with my next set of patches.
>
> Does everybody else have an ordered Configure.help? if yes, I'd accept
Most subsytems have their Configure.help entries ordered according to
the Config.in order.
> the patch to comply with common practice. If not, I would just say: who
> cares about the order, it's processed by {old,menu,x}config anyway.
I'm not religious regarding the order of Configure.help entries, and in
2.6 this problem will be non-existant.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-07-26 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-27 23:33 [2.4 patch] netfilter Configure.help cleanup Adrian Bunk
2003-06-30 4:38 ` Rusty Russell
2003-07-02 19:25 ` Marcelo Tosatti
2003-07-17 20:13 ` Adrian Bunk
2003-07-17 20:19 ` David S. Miller
2003-07-18 1:06 ` Rusty Russell
2003-07-25 20:50 ` Harald Welte
2003-07-26 10:50 ` Adrian Bunk [this message]
2003-07-17 20:11 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030726105021.GH22218@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=davem@redhat.com \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).