From: Con Kolivas <kernel@kolivas.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] sched-2.6.0-test1-G3
Date: Sat, 26 Jul 2003 11:56:32 +1000 [thread overview]
Message-ID: <200307261156.32209.kernel@kolivas.org> (raw)
In-Reply-To: <20030725231314.A1073@ss1000.ms.mff.cuni.cz>
Ingo
With this section of your patch:
+ if (!(p->time_slice % TIMESLICE_GRANULARITY) &&
that would requeue active tasks a variable duration into their running time
dependent on their task timeslice rather than every 50ms. Shouldn't it be:
+ if (!((task_timeslice(p) - p->time_slice) % TIMESLICE_GRANULARITY) &&
to ensure it is TIMESLICE_GRANULARITY into the timeslice of a process?
Con
next prev parent reply other threads:[~2003-07-26 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-25 19:59 [patch] sched-2.6.0-test1-G3, interactivity changes, audio latency Ingo Molnar
2003-07-25 21:13 ` [patch] sched-2.6.0-test1-G3 Rudo Thomas
2003-07-25 22:54 ` Diego Calleja García
2003-07-25 23:31 ` Rudo Thomas
2003-07-26 1:56 ` Con Kolivas [this message]
2003-07-27 12:33 ` Ingo Molnar
2003-07-25 22:58 ` [patch] sched-2.6.0-test1-G3, interactivity changes, audio latency Felipe Alfaro Solana
2003-07-25 23:30 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307261156.32209.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).