Re: request_firmware() backport to 2.4 kernels

[Manuel Estrada Sainz <ranty@debian.org>]

On Sat, Jul 26, 2003 at 11:04:27PM +0200, Marcel Holtmann wrote:
> Hi Manuel,
> 
> >  A while back request_firmware() was added to the 2.5 kernel series to
> >  support firmware needing drivers keeping the firmware images in
> >  userspace. And I also backported it to the 2.4 kernel series on top of
> >  procfs, but Marcelo didn't answer emails relating to it (there where
> >  probably other more important matters back then).
> >  
> >  Since then, the 2.4 backport has been deployed and tested with
> >  orinoco_usb driver variant (http://orinoco-usb.alioth.debian.org/),
> >  as you can see in the download statistics in alioth, there has been
> >  more than 400 downloads of the request_firmware enabled version
> >  (0.2.1). And drivers on the 2.5/2.6 series are being ported to use
> >  request_firmware() interface.
> 
> I've tested your patch with 2.4.22-pre8 and a modified version of my
> bfusb driver. It is working fine, but I get these log entries:
> 
> 	hub.c: new USB device 02:0c.0-2, assigned address 2
> 	firmware_class.c:call_helper: firmware: /sbin/hotplug firmware add
> 	remove_proc_entry: bfusb003002/loading busy, count=1
> 	remove_proc_entry: firmware/bfusb003002 busy, count=1
> 	BlueFRITZ! USB loading firmware
> 	de_put: deferred delete of loading
> 	de_put: deferred delete of bfusb003002
> 	BlueFRITZ! USB device ready
> 
> Is this a problem of your patch or is it a general /proc problem?

 I don't know if I can get around it, but it is a /proc issue, it dumps
 those messages when the kernel removes a file that is being used from
 userspace. Those messages should probably be changed into KERN_DEBUG.
 
> I already ported drivers/bluetooth/bfusb.c to use the request_firmware()
> interface and I will port drivers/bluetooth/bt3c_cs.c after this patch
> gets merged.

 Great.


 Have a nice day

 	Manuel

-- 
--- Manuel Estrada Sainz <ranty@debian.org>
                         <ranty@bigfoot.com>
			 <ranty@users.sourceforge.net>
------------------------ <manuel.estrada@hispalinux.es> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.