linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test1 devfs question
Date: Sun, 27 Jul 2003 02:30:01 +0400	[thread overview]
Message-ID: <200307270230.01823.arvidjaar@mail.ru> (raw)
In-Reply-To: <20030726135012.6386c185.akpm@osdl.org>

On Sunday 27 July 2003 00:50, Andrew Morton wrote:
> Andrey Borzenkov <arvidjaar@mail.ru> wrote:
> > > Is the problem simply that the device has moved from /dev/md1 to
> > > /dev/md/1? If so, is this change sufficient?
> > >
> > > diff -puN drivers/md/md.c~a drivers/md/md.c
> > > --- 25/drivers/md/md.c~a        2003-07-26 11:24:58.000000000 -0700
> > > +++ 25-akpm/drivers/md/md.c     2003-07-26 11:25:15.000000000 -0700
> > > @@ -3505,7 +3505,7 @@ int __init md_init(void)
> > >         for (minor=0; minor < MAX_MD_DEVS; ++minor) {
> > >                 devfs_mk_bdev(MKDEV(MAJOR_NR, minor),
> > >                                 S_IFBLK|S_IRUSR|S_IWUSR,
> > > -                               "md/%d", minor);
> > > +                               "md%d", minor);
> > >         }
> >
> > should not such things be done by devfsd in user space?
>
> Darned if I know - I do not have operational experience with devfs.
>
> > This patch makes it even more incompatible with 2.4 ...
>
> The patch is broken - 2.4 does /dev/md/2 as well.
>
> So what is the bug?  Why are people suddenly having problems with this?

it is hard to tell with the amount of information provided in bug report (even 
error message is not given). We have three cases here:

root=123456 (real major/minor number) or root=/dev/md2 (literal string). In 
both cases init/do_mount_devfs.c:create_dev() should notice that neither 
/dev/123456 nor /dev/md2 exist, search /dev for ROOT_DEV and create link from 
/dev/root to real device. If it does not work somethig is broken here, people 
who can reproduce it should add printk's to create_dev and find_in_devfs to 
see what happens. It may fail for /dev/md2 if block device name in sysfs 
differs from "md2" because then it won't find correct ROOT_DEV

root=/dev/md/2 (literal string) should work simply because /dev/root is linked 
directly to /dev/md/2

I do not have any raid devices nor possibility to create them so I cannot 
test.

-andrey

  reply	other threads:[~2003-07-26 22:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-26 19:51 Andrey Borzenkov
2003-07-26 20:50 ` Andrew Morton
2003-07-26 22:30   ` Andrey Borzenkov [this message]
2003-07-27  8:58     ` Daniele Venzano
  -- strict thread matches above, loose matches on Subject: below --
2003-07-28  7:13 "Andrey Borzenkov" 
2003-07-28  7:22 ` Andrew Morton
2003-07-25 18:53 Balram Adlakha
2003-07-26 10:45 ` Wiktor Wodecki
     [not found]   ` <20030726175214.GA2535@localhost.localdomain>
     [not found]     ` <20030726183750.GB789@gmx.de>
     [not found]       ` <20030726201919.GA5166@localhost.localdomain>
2003-07-26 20:35         ` Wiktor Wodecki
2003-07-25 11:08 Wiktor Wodecki
2003-07-25 11:18 ` Wiktor Wodecki
2003-07-26 11:12 ` Daniele Venzano
2003-07-26 18:25   ` Andrew Morton
2003-07-27 11:17     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307270230.01823.arvidjaar@mail.ru \
    --to=arvidjaar@mail.ru \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: 2.6.0-test1 devfs question' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).