linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dan carpenter <d_carpenter@sbcglobal.net>
To: Brad Hards <bhards@bigpond.net.au>
Cc: linux-kernel@vger.kernel.org, bcollins@debian.org
Subject: Re: [bug] ieee1394/sbp2 - sleeping in invalid context
Date: Sun, 27 Jul 2003 03:46:50 -0700	[thread overview]
Message-ID: <200307270346.50781.d_carpenter@sbcglobal.net> (raw)
In-Reply-To: <200307262224.13705.bhards@bigpond.net.au>

I think sbp2scsi_queuecommand is called from outside interrupt context.  The 
obvious but possibly wrong way to fix this would be to change the calls to 
hpsb_get_tlabel() to check in_atomic() instead of in_interrupt().

regards,
dan carpenter

On Saturday 26 July 2003 05:24 am, Brad Hards wrote:
> Debug: sleeping function called from invalid context at
> include/asm/semaphore.h:119 Call Trace:
>  [<c011c61e>] __might_sleep+0x5e/0x62
>  [<c031bfad>] hpsb_get_tlabel+0x5d/0x230
    calls down()

>  [<c0319d97>] alloc_hpsb_packet+0xa7/0xd0
    calls hpsb_get_tlabel(packet, in_interrupt() ? 0 : 1)

>  [<c031c4e2>] hpsb_make_writepacket+0xa2/0x140
    calls alloc_hpsb_packet(length + (length % 4 ? 4 - (length % 4) : 0));
    calls hpsb_get_tlabel(packet, in_interrupt() ? 0 : 1)

>  [<c032c5c6>] sbp2_link_orb_command+0x86/0x190
    calls hpsb_make_writepacket()

>  [<c032c773>] sbp2_send_command+0xa3/0xf0
    calls sbp2util_allocate_command_orb(scsi_id, SCpnt, done);

>  [<c032cd70>] sbp2scsi_queuecommand+0xb0/0x210
    calls sbp2_send_command under a spinlock



  reply	other threads:[~2003-07-27 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-26 12:24 [bug] ieee1394/sbp2 - sleeping in invalid context Brad Hards
2003-07-27 10:46 ` dan carpenter [this message]
2003-07-27 15:00   ` Ben Collins
2003-07-27 16:24   ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307270346.50781.d_carpenter@sbcglobal.net \
    --to=d_carpenter@sbcglobal.net \
    --cc=bcollins@debian.org \
    --cc=bhards@bigpond.net.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).