linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: PATCH: allow 2.6 to build on old old setups
Date: Sun, 27 Jul 2003 18:52:41 -0700	[thread overview]
Message-ID: <20030727185241.3288a973.davem@redhat.com> (raw)
In-Reply-To: <200307272026.h6RKQauS029828@hraefn.swansea.linux.org.uk>

On Sun, 27 Jul 2003 21:26:36 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> +#ifdef STT_REGISTER
>  		if (info->hdr->e_machine == EM_SPARC ||
>  		    info->hdr->e_machine == EM_SPARCV9) {
>  			/* Ignore register directives. */
>  			if (ELF_ST_TYPE(sym->st_info) == STT_REGISTER)
>  				break;
>  		}
> +#endif

This change is wrong.

If you're going to do this, it's much better to define it to the
correct value in this case (which is decimal '13').

  reply	other threads:[~2003-07-28  1:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-27 20:26 Alan Cox
2003-07-28  1:52 ` David S. Miller [this message]
2003-07-28 11:30   ` Alan Cox
2003-07-28 13:28     ` Mikael Pettersson
2003-07-28 14:17     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030727185241.3288a973.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: PATCH: allow 2.6 to build on old old setups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).