archive mirror
 help / color / mirror / Atom feed
From: Manuel Estrada Sainz <>
To: Matthew Wilcox <>
Cc: Marcel Holtmann <>,
	Linux Kernel Mailing List <>,, Patrick Mochel <>
Subject: Re: [PATCH] Re: Firmware loading problem
Date: Sun, 27 Jul 2003 23:21:34 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Jul 27, 2003 at 08:21:11PM +0100, Matthew Wilcox wrote:
> On Sat, Jul 26, 2003 at 11:04:58AM +0200, Manuel Estrada Sainz wrote:
> > 	- hopefully adapt drivers/pci/pci-sysfs.c to this changes
> > 		- Please double check, I didn't look very carefully on
> > 		  this.
> Definitely wrong.  I was going to undo this change since I realised how
> it doesn't work for you; but the change you made to the PCI code is wrong.
> It ends up copying everything to offset 0 from the buf address. 

 Exactly, and that is what sysfs code expects (with the rest of the
 patch), the buffer is just temporary storage, it doesn't really matter
 what offset you use as long as you don't write further than
 buffer+PAGE_SIZE and both sides of the issue agree.

> I wish Pat had cc'd me when making the change to the interface
> originally ;-(
> I'll whip up a patch in a few minutes.

 Have a nice day

--- Manuel Estrada Sainz <>
------------------------ <> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.

  reply	other threads:[~2003-07-28  0:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-22 14:45 Firmware loading problem Marcel Holtmann
2003-07-22 14:55 ` Manuel Estrada Sainz
2003-07-22 15:38   ` Marcel Holtmann
2003-07-26  9:04     ` [PATCH] " Manuel Estrada Sainz
2003-07-26 11:14       ` Marcel Holtmann
2003-07-26 11:26         ` Manuel Estrada Sainz
2003-07-27 19:21       ` Matthew Wilcox
2003-07-27 21:21         ` Manuel Estrada Sainz [this message]
2003-08-01 15:05           ` Manuel Estrada Sainz
2003-08-01 18:50             ` Manuel Estrada Sainz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).