From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272466AbTG1AUx (ORCPT ); Sun, 27 Jul 2003 20:20:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272588AbTG1AGV (ORCPT ); Sun, 27 Jul 2003 20:06:21 -0400 Received: from zeus.kernel.org ([204.152.189.113]:28659 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S272466AbTG0Wzq (ORCPT ); Sun, 27 Jul 2003 18:55:46 -0400 Date: Sun, 27 Jul 2003 23:21:34 +0200 From: Manuel Estrada Sainz To: Matthew Wilcox Cc: Marcel Holtmann , Linux Kernel Mailing List , greg@kroah.com, Patrick Mochel Subject: Re: [PATCH] Re: Firmware loading problem Message-ID: <20030727212134.GA9171@ranty.pantax.net> Reply-To: ranty@debian.org References: <1058885139.2757.27.camel@pegasus> <20030722145546.GC23593@ranty.pantax.net> <1058888301.2755.8.camel@pegasus> <20030726090458.GA16634@ranty.pantax.net> <20030727192111.GT1485@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030727192111.GT1485@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 27, 2003 at 08:21:11PM +0100, Matthew Wilcox wrote: > On Sat, Jul 26, 2003 at 11:04:58AM +0200, Manuel Estrada Sainz wrote: > > - hopefully adapt drivers/pci/pci-sysfs.c to this changes > > - Please double check, I didn't look very carefully on > > this. > > Definitely wrong. I was going to undo this change since I realised how > it doesn't work for you; but the change you made to the PCI code is wrong. > It ends up copying everything to offset 0 from the buf address. Exactly, and that is what sysfs code expects (with the rest of the patch), the buffer is just temporary storage, it doesn't really matter what offset you use as long as you don't write further than buffer+PAGE_SIZE and both sides of the issue agree. > I wish Pat had cc'd me when making the change to the interface > originally ;-( > > I'll whip up a patch in a few minutes. Great. Have a nice day Manuel -- --- Manuel Estrada Sainz ------------------------ ------------------- Let us have the serenity to accept the things we cannot change, courage to change the things we can, and wisdom to know the difference.