From: Jens Axboe <axboe@suse.de>
To: Lou Langholtz <ldl@aros.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@digeo.com>, Andrea Arcangeli <andrea@suse.de>,
NeilBrown <neilb@cse.unsw.edu.au>
Subject: Re: [PATCH 2.6.0-test2] fix broken blk_start_queue behavior
Date: Mon, 28 Jul 2003 09:12:00 +0200 [thread overview]
Message-ID: <20030728071200.GC25356@suse.de> (raw)
In-Reply-To: <3F24CA0D.4050901@aros.net>
On Mon, Jul 28 2003, Lou Langholtz wrote:
> This patch changes the behavior of blk_start_queue() so that request
> queues really do start up again after blk_start_queue() is called (on
> queues that were previously stopped via blk_stop_queue). The patch
> applies against 2.6.0-test2. I have tested this patch with the use of
> blk_stop_queue and blk_start_queue in my branch of the nbd block device
> driver (not yet released). blk_start_queue is also used in
> ./drivers/{block/cciss.c,ide/ide-io.c} which should see things function
> as intended now w.r.t. stopping and starting the request queue (but I do
> not know if anybody noticed that they weren't working correctly before).
> ide-io.c uses queue stop and start for power management handling. Please
> let me know if you've seen a problem before with that, especially if
> this patch fixes it - that will be happy news ;-)
> diff -urN linux-2.6.0-test2/drivers/block/ll_rw_blk.c linux-2.6.0-test2-unplug/drivers/block/ll_rw_blk.c
> --- linux-2.6.0-test2/drivers/block/ll_rw_blk.c 2003-07-27 19:02:48.000000000 -0600
> +++ linux-2.6.0-test2-unplug/drivers/block/ll_rw_blk.c 2003-07-28 00:36:35.366537142 -0600
> @@ -1027,10 +1027,10 @@
> */
> static inline void __generic_unplug_device(request_queue_t *q)
> {
> - if (!blk_remove_plug(q))
> + if (test_bit(QUEUE_FLAG_STOPPED, &q->queue_flags))
> return;
>
> - if (test_bit(QUEUE_FLAG_STOPPED, &q->queue_flags))
> + if (!blk_remove_plug(q))
> return;
>
> del_timer(&q->unplug_timer);
Patch looks correct, thanks! Guess our mails crossed in mid-air :)
--
Jens Axboe
next prev parent reply other threads:[~2003-07-28 6:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-27 18:24 blk_stop_queue/blk_start_queue confusion, problem, or bug??? Lou Langholtz
2003-07-28 6:43 ` Lou Langholtz
2003-07-28 7:00 ` [PATCH 2.6.0-test2] fix broken blk_start_queue behavior Lou Langholtz
2003-07-28 7:12 ` Jens Axboe [this message]
2003-07-28 7:01 ` blk_stop_queue/blk_start_queue confusion, problem, or bug??? Jens Axboe
2003-07-28 7:51 ` Lou Langholtz
2003-08-07 10:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030728071200.GC25356@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=andrea@suse.de \
--cc=ldl@aros.net \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).