* PATCH: console on by default if not embedded (save mucho pain)
@ 2003-07-27 20:02 Alan Cox
2003-07-28 7:12 ` Christoph Hellwig
2003-07-28 9:02 ` Roman Zippel
0 siblings, 2 replies; 3+ messages in thread
From: Alan Cox @ 2003-07-27 20:02 UTC (permalink / raw)
To: linux-kernel, torvalds
(Andi Kleen)
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/char/Kconfig linux-2.6.0-test2-ac1/drivers/char/Kconfig
--- linux-2.6.0-test2/drivers/char/Kconfig 2003-07-10 21:04:38.000000000 +0100
+++ linux-2.6.0-test2-ac1/drivers/char/Kconfig 2003-07-16 18:39:32.000000000 +0100
@@ -5,8 +5,9 @@
menu "Character devices"
config VT
- bool "Virtual terminal"
+ bool "Virtual terminal" if EMBEDDED
requires INPUT=y
+ default y
---help---
If you say Y here, you will get support for terminal devices with
display and keyboard devices. These are called "virtual" because you
@@ -35,8 +36,9 @@
shiny Linux system :-)
config VT_CONSOLE
- bool "Support for console on virtual terminal"
+ bool "Support for console on virtual terminal" if EMBEDDED
depends on VT
+ default y
---help---
The system console is the device which receives all kernel messages
and warnings and which allows logins in single user mode. If you
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: console on by default if not embedded (save mucho pain)
2003-07-27 20:02 PATCH: console on by default if not embedded (save mucho pain) Alan Cox
@ 2003-07-28 7:12 ` Christoph Hellwig
2003-07-28 9:02 ` Roman Zippel
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2003-07-28 7:12 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, torvalds
That doesn't make sense, VT off is perfectly fine for servers.
With the select CONFIG_INPUT if CONFIG_VT we have a much better
fix for the misconfig in ow anyway.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: console on by default if not embedded (save mucho pain)
2003-07-27 20:02 PATCH: console on by default if not embedded (save mucho pain) Alan Cox
2003-07-28 7:12 ` Christoph Hellwig
@ 2003-07-28 9:02 ` Roman Zippel
1 sibling, 0 replies; 3+ messages in thread
From: Roman Zippel @ 2003-07-28 9:02 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, torvalds, Andi Kleen
Hi,
On Sun, 27 Jul 2003, Alan Cox wrote:
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/char/Kconfig linux-2.6.0-test2-ac1/drivers/char/Kconfig
> --- linux-2.6.0-test2/drivers/char/Kconfig 2003-07-10 21:04:38.000000000 +0100
> +++ linux-2.6.0-test2-ac1/drivers/char/Kconfig 2003-07-16 18:39:32.000000000 +0100
> @@ -5,8 +5,9 @@
> menu "Character devices"
>
> config VT
> - bool "Virtual terminal"
> + bool "Virtual terminal" if EMBEDDED
> requires INPUT=y
> + default y
> ---help---
> If you say Y here, you will get support for terminal devices with
> display and keyboard devices. These are called "virtual" because you
The patch below is better and this is one actually fixes most of the
upgrade pain, as the other options have reasonable defaults.
I'm not sure we should hide that much behind EMBEDDED, for people who just
want to load an old config and expect something workable the patch below
is enough, other people have to search for all the options hidden behind
EMBEDDED.
bye, Roman
Index: drivers/char/Kconfig
===================================================================
RCS file: /home/other/cvs/linux/linux-2.6/drivers/char/Kconfig,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Kconfig
--- drivers/char/Kconfig 14 Jul 2003 09:22:00 -0000 1.1.1.1
+++ drivers/char/Kconfig 22 Jul 2003 08:08:26 -0000
@@ -6,7 +6,7 @@ menu "Character devices"
config VT
bool "Virtual terminal"
- requires INPUT=y
+ select INPUT
---help---
If you say Y here, you will get support for terminal devices with
display and keyboard devices. These are called "virtual" because you
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-07-28 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-27 20:02 PATCH: console on by default if not embedded (save mucho pain) Alan Cox
2003-07-28 7:12 ` Christoph Hellwig
2003-07-28 9:02 ` Roman Zippel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).