linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-net@vger.kernel.org, trivial@rustcorp.com.au
Subject: [patch 2.6.0-test2: com20020_cs.c doesn't compile
Date: Mon, 28 Jul 2003 15:03:44 +0200	[thread overview]
Message-ID: <20030728130344.GF25402@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0307271003360.3401-100000@home.osdl.org>

On Sun, Jul 27, 2003 at 10:08:40AM -0700, Linus Torvalds wrote:
>...
> Summary of changes from v2.6.0-test1 to v2.6.0-test2
> ============================================
>...
> Christoph Hellwig:
>...
>   o [ARCNET]: Fix module refcounting
>...

drivers/net/pcmcia/com20020_cs.c wasn't changed, resulting in the 
following compile error:

<--  snip  -->

...
  CC      drivers/net/pcmcia/com20020_cs.o
drivers/net/pcmcia/com20020_cs.c: In function `com20020_attach':
drivers/net/pcmcia/com20020_cs.c:240: error: structure has no member 
named `open_close_ll'
make[3]: *** [drivers/net/pcmcia/com20020_cs.o] Error 1

<--  snip -->


The following patch fixes it:


--- linux-2.6.0-test2-full-no-smp/drivers/net/pcmcia/com20020_cs.c.tmp	2003-07-28 14:57:35.000000000 +0200
+++ linux-2.6.0-test2-full-no-smp/drivers/net/pcmcia/com20020_cs.c	2003-07-28 14:58:55.000000000 +0200
@@ -171,14 +171,6 @@
 
 ======================================================================*/
 
-static void com20020cs_open_close(struct net_device *dev, bool open)
-{
-    if (open)
-	MOD_INC_USE_COUNT;
-    else
-	MOD_DEC_USE_COUNT;
-}
-
 static dev_link_t *com20020_attach(void)
 {
     client_reg_t client_reg;
@@ -237,7 +229,7 @@
     lp->backplane = backplane;
     lp->clockp = clockp;
     lp->clockm = clockm & 3;
-    lp->hw.open_close_ll = com20020cs_open_close;
+    lp->hw.owner = THIS_MODULE;
 
     link->irq.Instance = info->dev = dev;
     link->priv = info;



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-07-28 12:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-27 17:08 Linux v2.6.0-test2 Linus Torvalds
2003-07-27 17:23 ` where are the sources :-) Voicu Liviu
2003-07-27 17:27   ` Linus Torvalds
2003-07-27 19:24     ` Lukasz Trabinski
2003-07-28  3:03       ` Randy.Dunlap
2003-07-28  7:46         ` Lukasz Trabinski
2003-07-29  0:19           ` Mike Fedyk
2003-07-28  0:57     ` Erik Tews
2003-07-28  1:50       ` David S. Miller
2003-07-28  5:07       ` Voicu Liviu
2003-07-28  2:22     ` Larry McVoy
2003-07-28 10:03       ` Erik Tews
2003-07-27 19:42 ` Linux v2.6.0-test2 Harald Dunkel
2003-07-28  6:36   ` Otto Solares
2003-07-27 20:22 ` [PATCH] [TRIVIAL] Fix ipt_helper compilation. Was: " Florin Iucha
2003-07-28  1:55   ` David S. Miller
2003-07-27 21:45 ` Paco Ros
2003-07-28 13:03 ` Adrian Bunk [this message]
2003-07-28 13:11   ` [patch 2.6.0-test2: com20020_cs.c doesn't compile Christoph Hellwig
2003-07-28 13:27 ` Linux v2.6.0-test2 Adrian Bunk
2003-07-29  7:25   ` Francois Romieu
2003-07-29  7:33     ` Adrian Bunk
2003-07-29  0:14 ` Linux v2.6.0-test2 (compile stats) John Cherry
2003-07-30 21:27 ` dm: v4 ioctl interface (was: Re: Linux v2.6.0-test2) Geert Uytterhoeven
2003-07-30 21:39   ` Andrew Morton
2003-07-31  8:04     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030728130344.GF25402@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    --subject='Re: [patch 2.6.0-test2: com20020_cs.c doesn'\''t compile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).