Re: [PM] Make yenta work

Re: [PM] Make yenta work

[Michael Frank]

Russel has a patch pending which saves the (128) PCI registers as well. This is needed on my hardware for example

Regards
Michael


-- 
Powered by linux-2.6-test1-mm1. Compiled with gcc-2.95-3 - mature and rock solid

2.4/2.6 kernel testing: ACPI PCI interrupt routing, keyboard failure with
		        ACPI, PCI IRQ sharing and swsusp
2.6 kernel testing: PCMCIA yenta_socket, Suspend to RAM with ACPI S1-S3. 

More info on swsusp: http://sourceforge.net/projects/swsusp/

Re: [PM] Make yenta work

[Russell King]

On Mon, Aug 04, 2003 at 06:04:37PM -0700, Patrick Mochel wrote:
> I believe I saw a patch from Russell get in over the weekend that did 
> this, right? 

Correct.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: [PM] Make yenta work

[Patrick Mochel]

> This makes yenta work, and its really trivial...
> 								Pavel
> 
> Index: linux/drivers/pcmcia/yenta_socket.c
> ===================================================================
> --- linux.orig/drivers/pcmcia/yenta_socket.c	2003-07-22 13:39:42.000000000 +0200
> +++ linux/drivers/pcmcia/yenta_socket.c	2003-07-17 22:22:58.000000000 +0200
> @@ -899,7 +899,10 @@
>  
>  static int yenta_dev_suspend (struct pci_dev *dev, u32 state)
>  {
> -	return pcmcia_socket_dev_suspend(&dev->dev, state, 0);
> +	/* FIXME: We should really let devices to act on *all* levels :-(.
> +	   If you put something else than SUSPEND_SAVE_STATE,
> +	   pcmcia_socket_dev_suspend() will simply do nothing due to its check. */
> +	return pcmcia_socket_dev_suspend(&dev->dev, state, SUSPEND_SAVE_STATE);
>  }

I believe I saw a patch from Russell get in over the weekend that did 
this, right? 


	-pat

[PM] Make yenta work

[Pavel Machek]

Hi!

This makes yenta work, and its really trivial...
								Pavel

Index: linux/drivers/pcmcia/yenta_socket.c
===================================================================
--- linux.orig/drivers/pcmcia/yenta_socket.c	2003-07-22 13:39:42.000000000 +0200
+++ linux/drivers/pcmcia/yenta_socket.c	2003-07-17 22:22:58.000000000 +0200
@@ -899,7 +899,10 @@
 
 static int yenta_dev_suspend (struct pci_dev *dev, u32 state)
 {
-	return pcmcia_socket_dev_suspend(&dev->dev, state, 0);
+	/* FIXME: We should really let devices to act on *all* levels :-(.
+	   If you put something else than SUSPEND_SAVE_STATE,
+	   pcmcia_socket_dev_suspend() will simply do nothing due to its check. */
+	return pcmcia_socket_dev_suspend(&dev->dev, state, SUSPEND_SAVE_STATE);
 }
 
 

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]