linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Javier Achirica <achirica@ttd.net>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] airo driver: fix races, oops, etc..
Date: Tue, 29 Jul 2003 09:26:21 -0700	[thread overview]
Message-ID: <20030729162621.GA20410@bougret.hpl.hp.com> (raw)

Benjamin Herrenschmidt wrote :
> 
> Here's a patch against Linus current airo.c, it adds back some fixes I
> did during OLS on the previous version of this driver. I couldn't test
> this new 'fixed' version though as I don't have the airo card anymore:
> 
>  - Initialize the work_struct structures used by the driver
>  - Change most of schedule_work() to schedule_delayed_work(). The
>    problem with schedule_work() is that the worker_thread will never
>    schedule() if the work keeps getting added back to the list by the
>    callback, which typically happened with this driver when the xmit
>    work gets scheduled while the semaphore was used by a pending
>    command. Note that -ac tree has a modified version of this driver
>    that gets rid of this "over-smart" work queue stuff and uses normal
>    spinlock instead, probably at the expense of some latency...
>  - Fix a small signed vs. unsigned char issue
>  - Remove bogus pci_module_init(), use pci_register_driver() instead and
>    add missing pci_unregister_driver() so the module can now be removed
>    without leaving stale references (and thus avoid an oops next time
>    the driver list is walked by the device core).
> 
> Jeff, if you are ok with these, please send to Linus,

	Ben,

	Would you mind sending your patch to Javier (who is the
current maintainer). Javier did some work lately to fix some of those
problems, and I think your patch collides with it.
	Thanks...

	Jean

             reply	other threads:[~2003-07-29 16:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-29 16:26 Jean Tourrilhes [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-07-29 13:02 [PATCH] airo driver: fix races, oops, etc Benjamin Herrenschmidt
2003-08-05  8:53 ` Javier Achirica
2003-08-05  9:48   ` Benjamin Herrenschmidt
2003-08-05 10:18     ` Javier Achirica
2003-08-07  7:49     ` Javier Achirica
2003-08-07 14:51       ` Jeff Garzik
2003-08-08  8:54         ` Javier Achirica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030729162621.GA20410@bougret.hpl.hp.com \
    --to=jt@bougret.hpl.hp.com \
    --cc=achirica@ttd.net \
    --cc=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).