archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <>
To: Yoshinori Sato <>
Cc: Linus Torvalds <>,
	linux kernel Mailing List <>
Subject: Re: [PATCH] linux-2.6.0-test2 h8300 archtecure support update (1/6)
Date: Tue, 29 Jul 2003 21:20:56 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jul 28, 2003 at 11:18:23PM +0900, Yoshinori Sato wrote:
>  BOARD := $(board-y)

There is no need for renaming this variable, it is only reference three
times, so board-y would be fine.
Same goes for MODEL.

> +
> +vmlinux.bin: vmlinux
> +	$(OBJCOPY) -Obinary $< $@
> +
> +vmlinux.srec: vmlinux
> +	$(OBJCOPY) -Osrec $< $@
The above is more suited for a seperate boot/ directory.

boot := arch/$(ARCH)/boot
vmlinux.srec vmlinux.bin: vmlinux
	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@

	$(Q)$(MAKE) $(clean)=$(boot)

(The current archclean rule is plain wrong).

And in boot/Makefile

OBJCOPYFLAGS_vmlinux.srec := -Osrec
OBJCOPYFLAGS_vmlinux.bin  := -Obinary
$(obj)/vmlinux.srec $(obj)/vmlinux.bin: vmlinux FORCE
	$(call if_changed,objcopy)
	@echo '  Kernel: $@ is ready'

targets += vmlinux.srec vmlinux.bin

> +
> +define archhelp
> +  echo  'vmlinux.bin  - Create raw binary'
> +  echo  'vmlinux.srec - Create srec binary'
> +endef
OK - shall stay in arch/$(ARCH)/Makefile

> +
> +CLEAN_FILES += arch/$(ARCH)/vmlinux.bin arch/$(ARCH)/vmlinux.srec

Replaced by targets assignment in boot/Makefile.
But you shall add files related to asm-offsets:
CLEAN_FILES += include/asm-$(ARCH)/asm-offsets.h


  reply	other threads:[~2003-07-29 19:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-28 14:18 [PATCH] linux-2.6.0-test2 h8300 archtecure support update (1/6) Yoshinori Sato
2003-07-29 19:20 ` Sam Ravnborg [this message]
2003-07-30 12:20   ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).