From: Michael Driscoll <fenris@ulfheim.net>
To: linux-kernel@vger.kernel.org
Subject: Re: OOPS 2.6.0-test2, modprobe i810fb
Date: Wed, 30 Jul 2003 14:56:04 -0600 [thread overview]
Message-ID: <200307301456.04083.fenris@ulfheim.net> (raw)
In-Reply-To: <Pine.LNX.3.96.1030729225445.27753D-100000@gatekeeper.tmr.com>
On Tuesday 29 July 2003 20:56, Bill Davidsen wrote:
> > diff -puN drivers/char/agp/intel-agp.c~intel-agp-oops-fix
> > drivers/char/agp/intel-agp.c ---
> > 25/drivers/char/agp/intel-agp.c~intel-agp-oops-fix 2003-07-28
> > 22:30:30.000000000 -0700 +++
> > 25-akpm/drivers/char/agp/intel-agp.c 2003-07-28 22:30:53.000000000 -0700
> > @@ -1426,7 +1426,7 @@ static struct pci_device_id agp_intel_pc
> > .subvendor = PCI_ANY_ID,
> > .subdevice = PCI_ANY_ID,
> > },
> > - { }
> > + { 0, },
> > };
> >
> > MODULE_DEVICE_TABLE(pci, agp_intel_pci_table);
> >
> > _
>
> Sure about that last comma? Any compiler version issues?
It's allowed in K&R2 (and explicitly marked as a feature, see pp.218-219).
I don't have C99 handy but I'm pretty sure it's still legal.
--
Michael Driscoll, fenris@ulfheim.net
"A noble spirit embiggens the smallest man" -- J. Springfield
next prev parent reply other threads:[~2003-07-30 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-28 17:18 OOPS 2.6.0-test2, modprobe i810fb Pavel Rabel
2003-07-29 2:19 ` S. Anderson
2003-07-29 3:26 ` Andrew Morton
2003-07-29 5:18 ` S. Anderson
2003-07-29 5:32 ` Andrew Morton
2003-07-30 2:56 ` Bill Davidsen
2003-07-30 20:56 ` Michael Driscoll [this message]
2003-07-29 5:59 ` Andrew Morton
2003-07-29 7:24 ` S. Anderson
2003-07-29 7:54 ` Andrew Morton
2003-07-29 8:18 ` S. Anderson
2003-07-29 12:00 ` Alan Cox
2003-07-29 19:59 ` Andrew Morton
2003-07-29 23:04 ` S. Anderson
2003-07-29 9:34 ` Pavel Rabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307301456.04083.fenris@ulfheim.net \
--to=fenris@ulfheim.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).