From: Andrew Morton <akpm@osdl.org>
To: Oleg Drokin <green@namesys.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.5] reiserfs: fix races between link and unlink on same file
Date: Thu, 31 Jul 2003 13:37:08 -0700 [thread overview]
Message-ID: <20030731133708.04bcd0c9.akpm@osdl.org> (raw)
In-Reply-To: <20030731144204.GP14081@namesys.com>
Oleg Drokin <green@namesys.com> wrote:
>
> This patch (originally by Chris Mason) fixes link/unlink races in reiserfs.
>
Could you describe the race a little more please? Why is the VFS's hold of
i_sem on the parent directory not sufficient?
> +
> + /*
> + * we schedule before doing the add_save_link call, save the link
> + * count so we don't race
This comment would seem to imply lock_kernel()-based locking, but
lock_kernel() is not held here.
next prev parent reply other threads:[~2003-07-31 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 14:42 [PATCH] [2.5] reiserfs: fix races between link and unlink on same file Oleg Drokin
2003-07-31 20:37 ` Andrew Morton [this message]
2003-08-01 11:10 ` Oleg Drokin
2003-08-01 14:05 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030731133708.04bcd0c9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).