From: Andrew Morton <akpm@osdl.org>
To: Chip Salzenberg <chip@pobox.com>
Cc: SteveD@redhat.com, neilb@cse.unsw.edu.au,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Kernel 2.4 and 2.6 disagree about NFSEXP_CROSSMNT - upward incompatibility, please fix
Date: Thu, 31 Jul 2003 15:05:48 -0700 [thread overview]
Message-ID: <20030731150548.0cacb93b.akpm@osdl.org> (raw)
In-Reply-To: <20030731182332.GH18733@perlsupport.com>
Chip Salzenberg <chip@pobox.com> wrote:
>
> According to Steve Dickson:
> > It seems in nfs-utils-1.05 (actually it happen in 1.0.4)
> > the NFSEXP_CROSSMNT define was changed to 0x4000 ....
>
> This looks like an actual kernel incompatibility 2.4 <-> 2.6, as
> the 2.4 and 2.6 trees disagree about the value of NFSEXP_CROSSMNT.
yup.
> > So could please add this patch that simply switchs the bits
> > so NFSEXP_CROSSMNT stays the same and the new NFSEXP_NOHIDE define
> > gets the higher bit?
>
> And 2.6's include/linux/nfsd/export.h needs the same fix. This needs
> to go in before the 2.6.0 release or nfs-utils is in deep kimchi.
Like this?
diff -puN include/linux/nfsd/export.h~nfs-flags-untangle include/linux/nfsd/export.h
--- 25/include/linux/nfsd/export.h~nfs-flags-untangle Thu Jul 31 15:04:25 2003
+++ 25-akpm/include/linux/nfsd/export.h Thu Jul 31 15:04:49 2003
@@ -35,12 +35,12 @@
#define NFSEXP_UIDMAP 0x0040
#define NFSEXP_KERBEROS 0x0080 /* not available */
#define NFSEXP_SUNSECURE 0x0100
-#define NFSEXP_NOHIDE 0x0200
+#define NFSEXP_CROSSMNT 0x0200
#define NFSEXP_NOSUBTREECHECK 0x0400
#define NFSEXP_NOAUTHNLM 0x0800 /* Don't authenticate NLM requests - just trust */
#define NFSEXP_MSNFS 0x1000 /* do silly things that MS clients expect */
#define NFSEXP_FSID 0x2000
-#define NFSEXP_CROSSMNT 0x4000
+#define NFSEXP_NOHIDE 0x4000
#define NFSEXP_ALLFLAGS 0x7FFF
_
next prev parent reply other threads:[~2003-07-31 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 17:12 nfs-utils-1.0.5 is not backwards compatible with 2.4 Steve Dickson
2003-07-31 18:23 ` Kernel 2.4 and 2.6 disagree about NFSEXP_CROSSMNT - upward incompatibility, please fix Chip Salzenberg
2003-07-31 22:05 ` Andrew Morton [this message]
2003-08-01 2:55 ` nfs-utils-1.0.5 is not backwards compatible with 2.4 Neil Brown
2003-08-01 12:43 ` Steve Dickson
2003-08-04 0:52 ` Neil Brown
2003-08-01 14:38 ` Chip Salzenberg
2003-08-04 0:55 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030731150548.0cacb93b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=SteveD@redhat.com \
--cc=chip@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).