From: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Ren <l.s.r@web.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Inline vfat_strnicmp()
Date: Fri, 1 Aug 2003 08:55:48 +0300 [thread overview]
Message-ID: <200308010546.h715kJj24299@Port.imtp.ilyichevsk.odessa.ua> (raw)
In-Reply-To: <87zniuwx81.fsf@devron.myhome.or.jp>
On 31 July 2003 18:07, OGAWA Hirofumi wrote:
> Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes:
>
> > Yes, but some future version would.
> >
> > Since there is no substantial wins in hunting down
> > such statics, and there is some risk of code bloat when
> > big inlined statics get called from more that one callsite,
> > and it will be automatically handled by smarter compiler someday,
> > I think it makes perfect sense to avoid doing this.
>
> Could you tell me, if compiler does it in future? I'll gladly kill
> that inline.
I can't be 100.00% sure it will happen. I'd say 98.234235% ;)
Andrew Morton kills extra large inlines, and you are creating them :(
That's not ok. Just leave those poor static functions alone
until compiler will do them, all at once.
There are lots of other stuff to do in the kernel source.
--
vda
next prev parent reply other threads:[~2003-08-01 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-27 15:21 [PATCH] Inline vfat_strnicmp() Ren
2003-07-27 16:33 ` OGAWA Hirofumi
2003-07-31 12:33 ` Denis Vlasenko
2003-07-31 13:52 ` OGAWA Hirofumi
2003-07-31 14:04 ` David Weinehall
2003-07-31 15:00 ` OGAWA Hirofumi
2003-07-31 14:06 ` Denis Vlasenko
2003-07-31 15:07 ` OGAWA Hirofumi
2003-08-01 5:55 ` Denis Vlasenko [this message]
2003-08-01 15:47 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308010546.h715kJj24299@Port.imtp.ilyichevsk.odessa.ua \
--to=vda@port.imtp.ilyichevsk.odessa.ua \
--cc=hirofumi@mail.parknet.co.jp \
--cc=l.s.r@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).