From: Diffie <diffie@blazebox.homeip.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Badness in device_release at drivers/base/core.c:84
Date: Sat, 2 Aug 2003 01:53:24 -0400 [thread overview]
Message-ID: <20030802055323.GB3613@blazebox.homeip.net> (raw)
In-Reply-To: <20030801144455.450d8e52.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
On Fri, Aug 01, 2003 at 02:44:55PM -0700, Andrew Morton wrote:
>
> This patch should fix the oops.
>
> As for why the proc reading code was unable to locate the HBA: dunno, but
> this is a first step.
>
> Or maybe you don't have any adaptec controllers in the machine?
>
> (jejb, please apply..)
>
>
> 25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix drivers/scsi/aic7xxx_old/aic7xxx_proc.c
> --- 25/drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix Fri Aug 1 14:41:14 2003
> +++ 25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c Fri Aug 1 14:41:20 2003
> @@ -92,7 +92,7 @@ aic7xxx_proc_info ( struct Scsi_Host *HB
>
> HBAptr = NULL;
>
> - for(p=first_aic7xxx; p->host != HBAptr; p=p->next)
> + for(p=first_aic7xxx; p && p->host != HBAptr; p=p->next)
> ;
>
> if (!p)
>
> _
>
>
Andrew,
I will test the patch shortly :). I do have Adaptec AHA-2940U2W
controller installed in my machine, http://www.blazebox.homeip.net:81/diffie/images/comp/amd_box8.png.
From dmesg:
(scsi0) <Adaptec AHA-294X Ultra2 SCSI host adapter> found at PCI 1/10/0
(scsi0) Wide Channel, SCSI ID=7, 32/255 SCBs
(scsi0) Downloading sequencer code... 398 instructions downloaded
scsi0 : Adaptec AHA274x/284x/294x (EISA/VLB/PCI-Fast SCSI) 5.2.6/5.2.0
<Adaptec AHA-294X Ultra2 SCSI host adapter>
sda: Spinning up disk......<5>Attached scsi disk sda at scsi0, channel 0, id 3, lun 0
(scsi0:0:6:0) Synchronous at 80.0 Mbyte/sec, offset 63.
SCSI device sdb: 71687340 512-byte hdwr sectors (36704 MB)
SCSI device sdb: drive cache: write back
/dev/scsi/host0/bus0/target6/lun0: p1 p2 p3 p4 < p5 p6 p7 p8 p9 p10 >
From lspci:
01:0a.0 SCSI storage controller: Adaptec AHA-2940U2/U2W
Regards,
Paul
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-08-02 5:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-01 18:22 Badness in device_release at drivers/base/core.c:84 Diffie
2003-08-01 21:27 ` Greg KH
2003-08-02 5:40 ` Diffie
2003-08-01 21:44 ` Andrew Morton
2003-08-01 23:27 ` Mike Anderson
2003-08-02 5:57 ` Diffie
2003-08-02 5:53 ` Diffie [this message]
2003-08-03 1:55 ` Diffie
2003-08-03 2:07 ` Andrew Morton
2003-08-03 21:47 ` Diffie
2003-08-03 21:52 ` Andrew Morton
2003-08-03 22:23 ` Diffie
2003-08-03 22:31 ` Diffie
2003-08-04 16:30 ` Patrick Mansfield
2003-08-04 17:48 ` Paul Blazejowski
2003-08-04 18:26 ` Paul Blazejowski
2003-08-04 18:57 ` Patrick Mansfield
2003-08-04 19:36 ` Justin T. Gibbs
2003-08-05 2:21 ` Paul Blazejowski
2003-08-05 10:20 ` wb
2003-08-05 16:10 ` Ishikawa
2003-08-06 16:58 ` Paul Blazejowski
2003-08-06 17:20 ` Chiaki
2003-08-13 2:03 ` Chiaki
2003-08-06 16:55 ` Paul Blazejowski
2003-08-05 7:18 ` Paul Blazejowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030802055323.GB3613@blazebox.homeip.net \
--to=diffie@blazebox.homeip.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).