archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <>
To: Zwane Mwaikambo <>
Subject: Re: [PATCH] [1/2] random: SMP locking
Date: Sat, 2 Aug 2003 11:39:07 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Zwane Mwaikambo <> wrote:
> Perhaps might_sleep() in *_user, copy_* etc is in order?

Probably, with a little care.

A userspace copy while in an atomic region is actually legal, on behalf of
the read() and write() pagecache copy functions: if we take a fault while
holding an atomic kmap, the fault handler bales and the usercopy returns a
short copy.

In other words: if you stick a might_sleep() in __copy_from_user() and
__copy_to_user() you get a false positive on every read() and write().

We could probably add it to copy_to_user() and copy_from_user() though.

  parent reply	other threads:[~2003-08-02 18:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-02  4:24 [PATCH] [1/2] random: SMP locking Oliver Xymoron
2003-08-02 11:00 ` Andrew Morton
2003-08-02 12:35   ` Zwane Mwaikambo
2003-08-02 14:43     ` Matt Mackall
2003-08-02 15:02       ` Zwane Mwaikambo
2003-08-02 18:39     ` Andrew Morton [this message]
2003-08-02 18:42     ` Matt Mackall
2003-08-02 14:32   ` Matt Mackall
2003-08-02 19:00     ` Andrew Morton
2003-08-02 19:33       ` Matt Mackall
2003-08-02 19:46         ` Andrew Morton
2003-08-02 20:14           ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).