From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test2-mm2
Date: Sat, 2 Aug 2003 12:04:18 -0700 [thread overview]
Message-ID: <20030802120418.02785fda.akpm@osdl.org> (raw)
In-Reply-To: <20030802151905.GA5344@suse.de>
Dave Jones <davej@codemonkey.org.uk> wrote:
>
> On Wed, Jul 30, 2003 at 10:38:10PM -0700, Andrew Morton wrote:
>
> > +intel-agp-oops-fix.patch
> > another oops fix
>
> patch is correct, but I'm wondering what managed to iterate that
> far, do you have any hw info on the box that oopsed ?
Nah, that patch is bogus:
.subdevice = PCI_ANY_ID,
},
- { }
+ { 0, },
These two things are equivalent: it is a no-op.
The bug was actually the __devinitdata problem.
> > +pci_device_id-devinitdata.patch
> > Move lots of PCI device_id tables out of __initdata
>
> How embarressing. Russell King noticed a similar problem
> in agpgart a while back, and I overlooked the adjacent struct.
> Likewise, I goofed in cpufreq. Oops. Thanks for fixing them up.
Greg did a tree-wide sweep and removed __devinitdata and __initdata from a
large number of pci_device_id tables. Linus merged that yesterday.
prev parent reply other threads:[~2003-08-02 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 5:38 2.6.0-test2-mm2 Andrew Morton
2003-07-31 9:50 ` 2.6.0-test2-mm2 Peter Osterlund
2003-07-31 10:57 ` 2.6.0-test2-mm2 Ramón Rey Vicente
2003-08-01 11:00 ` 2.6.0-test2-mm2 Jose Luis Domingo Lopez
2003-07-31 15:06 ` 2.6.0-test2-mm2: BTTV build error Adrian Bunk
2003-08-04 9:13 ` Gerd Knorr
2003-08-09 20:01 ` Adrian Bunk
2003-07-31 19:37 ` 2.6.0-test2-mm2 Apurva Mehta
2003-07-31 20:33 ` 2.6.0-test2-mm2 Mike Fedyk
2003-08-02 15:19 ` 2.6.0-test2-mm2 Dave Jones
2003-08-02 19:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030802120418.02785fda.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).