[PATCH 2.4] iptables tftp uninitialized variable fix

[PATCH 2.4] iptables tftp uninitialized variable fix

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

Hi Davem!

The below patch fixes an uninitialized return variable in 2.4.x

Please apply, thanks.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1019  -> 1.1020 
#	net/ipv4/netfilter/ip_nat_tftp.c	1.1     -> 1.2    
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/07/21	kaber@trash.net	1.1020
# [NETFILTER]: fix uninitialized return value in ip_nat_tftp.c
# --------------------------------------------
#
diff -Nru a/net/ipv4/netfilter/ip_nat_tftp.c b/net/ipv4/netfilter/ip_nat_tftp.c
--- a/net/ipv4/netfilter/ip_nat_tftp.c	Mon Jul 21 02:20:24 2003
+++ b/net/ipv4/netfilter/ip_nat_tftp.c	Mon Jul 21 02:20:24 2003
@@ -153,7 +153,7 @@
 
 static int __init init(void)
 {
-	int i, ret;
+	int i, ret = 0;
 	char *tmpname;
 
 	if (!ports[0])
-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH 2.4] iptables tftp uninitialized variable fix

[David S. Miller]

I've applied all of your 2.6.x and 2.4.x patches,
thanks Harald.