From: Andries Brouwer <aebr@win.tue.nl>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
axboe@suse.de
Cc: Erik Andersen <andersen@codepoet.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE
Date: Sat, 2 Aug 2003 19:42:29 +0200 [thread overview]
Message-ID: <20030802174229.GA3741@win.tue.nl> (raw)
In-Reply-To: <Pine.SOL.4.30.0308021506550.7779-100000@mion.elka.pw.edu.pl>
On Sat, Aug 02, 2003 at 03:10:43PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Sat, 2 Aug 2003, Andries Brouwer wrote:
>
> > Maybe it is intended to protect against old disks that do not
> > understand these new commands. Andre? Bart? Alan?
>
> Some Samsung disks lock up. Probably we should check if HPA
> command set is supported instead of using IDE_STROKE_LIMIT.
OK, so we have to investigate. This strange test was inserted
in 2.4 and 2.5 via Alan, and google gives me Alan's changelog:
Linux 2.5.66-ac1
o Don't issue WIN_SET_MAX on older drivers (Jens Axboe)
(Breaks some Samsung)
So, now the question is to Jens: what was the situation?
What disk, kernel, identify output?
If possible we would like to remove the test and test the
right bits instead. But if that Samsung disk claims it
supports HPA and doesnt..
Andries
[By the way, google also shows examples where this test
breaks a setup, so removing it might be a good idea
under all circumstances. The usual jumper goes from
above 32GB to 32GB, and from below 32GB to 2GB.
There are also examples of the latter kind solved
by STROKE, but no longer by STROKE + faulty test.]
next prev parent reply other threads:[~2003-08-02 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-02 8:42 ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE Erik Andersen
2003-08-02 12:45 ` Andries Brouwer
2003-08-02 13:10 ` Bartlomiej Zolnierkiewicz
2003-08-02 17:42 ` Andries Brouwer [this message]
2003-08-02 21:06 ` Alan Cox
2003-08-02 23:34 ` [PATCH] " Erik Andersen
2003-08-03 1:26 ` Andries Brouwer
2003-08-03 2:12 ` Erik Andersen
2003-08-03 9:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030802174229.GA3741@win.tue.nl \
--to=aebr@win.tue.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=andersen@codepoet.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).