linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Jakob Oestergaard <jakob@ostenfeld.dk>
Cc: Dave Jones <davej@codemonkey.org.uk>,
	linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [2.4 patch] fix a compile warning in sbc60xxwdt.c
Date: Sun, 3 Aug 2003 12:57:41 +0200	[thread overview]
Message-ID: <20030803105741.GM16426@fs.tum.de> (raw)

I got the following compile warning in 2.4.22-pre10:

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.22-pre10-full/include -
Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=sbc60xxwdt  -c -o sbc60xxwdt.o sbc60xxwdt.c
sbc60xxwdt.c: In function `sbc60xxwdt_init':
sbc60xxwdt.c:338: warning: label `err_out' defined but not used
...

<--  snip  -->


The following simple fix (taken from 2.6.0-test2) fixes it:

--- linux-2.4.22-pre10-full/drivers/char/sbc60xxwdt.c	2002-11-29 00:53:12.000000000 +0100
+++ linux-2.6.0-test2-full/drivers/char/watchdog/sbc60xxwdt.c	2003-07-27 19:05:13.000000000 +0200
@@ -335,7 +340,7 @@
 	release_region(WDT_START,1);
 err_out_region1:
 	release_region(WDT_STOP,1);
-err_out:
+/* err_out: */
 	return rc;
 }
 




I've tested the compilation with 2.4.22-pre10.

Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2003-08-03 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-03 10:57 Adrian Bunk [this message]
2003-08-05 16:36 ` [2.4 patch] fix a compile warning in sbc60xxwdt.c Marcelo Tosatti
2003-08-05 21:41   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030803105741.GM16426@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=davej@codemonkey.org.uk \
    --cc=jakob@ostenfeld.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).