linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Badness in local_bh_enable at kernel/softirq.c:113
@ 2003-08-03 11:51 Jan-Frode Myklebust
  2003-08-03 12:45 ` Andries Brouwer
  0 siblings, 1 reply; 3+ messages in thread
From: Jan-Frode Myklebust @ 2003-08-03 11:51 UTC (permalink / raw)
  To: linux-kernel

Bugzilla seems to be in trouble, so I'm sending it here..

Kernel: 2.6.0-test2
Distribution: gentoo
Hardware Environment: AMD AthlonXP
Software Environment:

ppp-2.4.1-r14
pptpclient-1.2.0

Problem Description:

My pptp client connections keeps dying, syslogging:

Aug  3 13:35:36 [pppd] Using interface ppp0
Aug  3 13:35:36 [pppd] Connect: ppp0 <--> /dev/pts/4
Aug  3 13:35:36 [/etc/hotplug/net.agent] NET add event not supported
Aug  3 13:35:38 [pptp] anon log[decaps_hdlc:pptp_gre.c:198]: PPP mode seems to be Asynchronous._
Aug  3 13:35:39 [pppd] Remote message: Welcome^M^J
Aug  3 13:35:41 [pppd] local  IP address 129.177.43.23
Aug  3 13:35:41 [pppd] remote IP address 129.177.43.1
Aug  3 13:36:07 [pppd] Unsupported protocol 0xd44a received
Aug  3 13:36:57 [pppd] Unsupported protocol 0xcc4a received
aug  3 13:38:20 [su(pam_unix)] session opened for user root by (uid=1001)
Aug  3 13:39:21 [anacron] Job `cron.daily' started
Aug  3 13:39:29 [crontab] (root) LIST (root)_
Aug  3 13:39:37 [pptp] anon warn[decaps_gre:pptp_gre.c:300]: short read (-1): Message too long
Aug  3 13:39:37 [pptp] anon log[callmgr_main:pptp_callmgr.c:234]: Closing connection
Aug  3 13:39:37 [pptp] anon log[pptp_conn_close:pptp_ctrl.c:308]: Closing PPTP connection
Aug  3 13:39:39 [pptp] anon log[call_callback:pptp_callmgr.c:74]: Closing connection
Aug  3 13:39:39 [pppd] Hangup (SIGHUP)
Aug  3 13:39:39 [kernel] Badness in local_bh_enable at kernel/softirq.c:113
Aug  3 13:39:39 [pppd] Modem hangup
Aug  3 13:39:39 [pppd] Connection terminated.
Aug  3 13:39:39 [pppd] Connect time 4.1 minutes.
Aug  3 13:39:39 [pppd] Sent 310556 bytes, received 1615363 bytes.
Aug  3 13:39:39 [/etc/hotplug/net.agent] NET remove event not supported
Aug  3 13:39:39 [pppd] Failed to open /dev/pts/4: No such file or directory
                - Last output repeated 9 times -
Aug  3 13:39:39 [pppd] Exit.


And giving this call trace in the kernel log:

Badness in local_bh_enable at kernel/softirq.c:113
Call Trace:
 [<c0120b88>] local_bh_enable+0x88/0x90
 [<c037bd54>] ppp_async_push+0xa4/0x1b0
 [<c015dd04>] __lookup_hash+0x64/0xd0
 [<c037b621>] ppp_asynctty_wakeup+0x31/0x60
 [<c032bff6>] pty_unthrottle+0x56/0x60
 [<c032898a>] check_unthrottle+0x3a/0x40
 [<c0328a34>] n_tty_flush_buffer+0x14/0x50
 [<c032c3ae>] pty_flush_buffer+0x5e/0x60
 [<c03253ac>] do_tty_hangup+0x3ac/0x420
 [<c0326823>] release_dev+0x5b3/0x600
 [<c03fc000>] snd_pcm_oss_init_substream+0x50/0x90
 [<c01402fe>] zap_pmd_range+0x4e/0x70
 [<c014036e>] unmap_page_range+0x4e/0x90
 [<c0326beb>] tty_release+0x2b/0x60
 [<c015091e>] __fput+0xce/0xe0
 [<c014ef5b>] filp_close+0x4b/0x80
 [<c011e5fc>] put_files_struct+0x6c/0xe0
 [<c011f1c5>] do_exit+0x165/0x340
 [<c011f3d5>] sys_exit+0x15/0x20
 [<c010930b>] syscall_call+0x7/0xb



Steps to reproduce:

Don't know how to trigger it, but it happens all the time.



   -jf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Badness in local_bh_enable at kernel/softirq.c:113
  2003-08-03 11:51 Badness in local_bh_enable at kernel/softirq.c:113 Jan-Frode Myklebust
@ 2003-08-03 12:45 ` Andries Brouwer
  0 siblings, 0 replies; 3+ messages in thread
From: Andries Brouwer @ 2003-08-03 12:45 UTC (permalink / raw)
  To: linux-kernel, janfrode

On Sun, Aug 03, 2003 at 01:51:31PM +0200, Jan-Frode Myklebust wrote:

> Kernel: 2.6.0-test2
> ppp-2.4.1-r14
> pptpclient-1.2.0
> 
> Problem Description:
> 
> My pptp client connections keeps dying, syslogging:

> Aug  3 13:35:36 [pppd] Using interface ppp0
> Aug  3 13:35:36 [pppd] Connect: ppp0 <--> /dev/pts/4
> Aug  3 13:35:36 [/etc/hotplug/net.agent] NET add event not supported
> Aug  3 13:35:38 [pptp] anon log[decaps_hdlc:pptp_gre.c:198]: PPP mode seems to be Asynchronous._
> Aug  3 13:35:39 [pppd] Remote message: Welcome^M^J
> Aug  3 13:35:41 [pppd] local  IP address 129.177.43.23
> Aug  3 13:35:41 [pppd] remote IP address 129.177.43.1
> Aug  3 13:36:07 [pppd] Unsupported protocol 0xd44a received
> Aug  3 13:36:57 [pppd] Unsupported protocol 0xcc4a received
> aug  3 13:38:20 [su(pam_unix)] session opened for user root by (uid=1001)
> Aug  3 13:39:21 [anacron] Job `cron.daily' started
> Aug  3 13:39:29 [crontab] (root) LIST (root)_
> Aug  3 13:39:37 [pptp] anon warn[decaps_gre:pptp_gre.c:300]: short read (-1): Message too long
> Aug  3 13:39:37 [pptp] anon log[callmgr_main:pptp_callmgr.c:234]: Closing connection
> Aug  3 13:39:37 [pptp] anon log[pptp_conn_close:pptp_ctrl.c:308]: Closing PPTP connection
> Aug  3 13:39:39 [pptp] anon log[call_callback:pptp_callmgr.c:74]: Closing connection
> Aug  3 13:39:39 [pppd] Hangup (SIGHUP)
> Aug  3 13:39:39 [kernel] Badness in local_bh_enable at kernel/softirq.c:113
> 
> And giving this call trace in the kernel log:
> 
> Badness in local_bh_enable at kernel/softirq.c:113
> Call Trace:
>  [<c0120b88>] local_bh_enable+0x88/0x90
>  [<c037bd54>] ppp_async_push+0xa4/0x1b0
>  [<c015dd04>] __lookup_hash+0x64/0xd0
>  [<c037b621>] ppp_asynctty_wakeup+0x31/0x60
>  [<c032bff6>] pty_unthrottle+0x56/0x60
>  [<c032898a>] check_unthrottle+0x3a/0x40
>  [<c0328a34>] n_tty_flush_buffer+0x14/0x50
>  [<c032c3ae>] pty_flush_buffer+0x5e/0x60
>  [<c03253ac>] do_tty_hangup+0x3ac/0x420

The badness in local_bh_enable part is well-known (but I don't know
whether anybody fixed it in -mm already). It was (is?) must-fix bug
#1 on Andrew's list.

(What happens is that do_tty_hangup() does
	local_irq_save(flags); // FIXME: is this safe?
	*flush_buffer(tty);
where the flush buffer ends up calling ppp_async_push(), which does
	spin_lock_bh ... spin_unlock_bh
and spin_unlock_bh() calls local_bh_enable() which does
	WARN_ON(irqs_disabled());

So, we know that it happens, and why it happens, and can trivially
remove the symptom with an ostrich head-in-sand patch.)

This happens when pppd dies. I don't know why your pppd has problems.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Badness in local_bh_enable at kernel/softirq.c:113
@ 2003-08-07  8:14 Jan De Luyck
  0 siblings, 0 replies; 3+ messages in thread
From: Jan De Luyck @ 2003-08-07  8:14 UTC (permalink / raw)
  To: linux-kernel

Hello list,
F.Y.I:

My ppp link went down, and kppp hung. I had to kill -9 it, after which this showed up in my logs:

Aug  7 10:10:08 laptop pppd[1090]: tcsetattr: Invalid argument
Aug  7 10:10:08 laptop pppd[1090]: Exit.
Aug  7 10:11:10 laptop kernel: Badness in local_bh_enable at kernel/softirq.c:113
Aug  7 10:11:10 laptop kernel: Call Trace:
Aug  7 10:11:10 laptop kernel:  [local_bh_enable+134/144] local_bh_enable+0x86/0x90
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+282550698/1070065048] ppp_async_push+0xa2/0x190 [ppp_async]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+282548837/1070065048] ppp_asynctty_wakeup+0x2d/0x60 [ppp_async]
Aug  7 10:11:10 laptop kernel:  [uart_flush_buffer+109/128] uart_flush_buffer+0x6d/0x80
Aug  7 10:11:10 laptop kernel:  [do_tty_hangup+1155/1264] do_tty_hangup+0x483/0x4f0
Aug  7 10:11:10 laptop kernel:  [uart_unconfigure_port+152/160] uart_unconfigure_port+0x98/0xa0
Aug  7 10:11:10 laptop kernel:  [uart_unregister_port+127/153] uart_unregister_port+0x7f/0x99
Aug  7 10:11:10 laptop kernel:  [unregister_serial+23/32] unregister_serial+0x17/0x20
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284542522/1070065048] serial_remove+0xa2/0xb0 [8250_cs]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284546506/1070065048] serial_event+0x52/0x100 [8250_cs]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284497878/1070065048] send_event+0x5e/0x70 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284498008/1070065048] socket_remove_drivers+0x20/0x50 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284498075/1070065048] socket_shutdown+0x13/0x60 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284499467/1070065048] socket_remove+0x13/0x60 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284499650/1070065048] socket_detect_change+0x6a/0x90 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284500032/1070065048] pccardd+0x158/0x1c0 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [default_wake_function+0/48] default_wake_function+0x0/0x30
Aug  7 10:11:10 laptop kernel:  [ret_from_fork+6/20] ret_from_fork+0x6/0x14
Aug  7 10:11:10 laptop kernel:  [default_wake_function+0/48] default_wake_function+0x0/0x30
Aug  7 10:11:10 laptop kernel:  [acqseq_lock.5+284499688/1070065048] pccardd+0x0/0x1c0 [pcmcia_core]
Aug  7 10:11:10 laptop kernel:  [kernel_thread_helper+5/16] kernel_thread_helper+0x5/0x10

Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-08-07  8:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-03 11:51 Badness in local_bh_enable at kernel/softirq.c:113 Jan-Frode Myklebust
2003-08-03 12:45 ` Andries Brouwer
2003-08-07  8:14 Jan De Luyck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).