linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [TRIVIAL] kill annoying submenus in fs/Kconfig
@ 2003-08-05  7:27 Tomas Szepe
  0 siblings, 0 replies; 4+ messages in thread
From: Tomas Szepe @ 2003-08-05  7:27 UTC (permalink / raw)
  To: torvalds; +Cc: lkml

Resend: patch against test2-bk4.
Kill annoying submenus in fs/Kconfig.

-- 
Tomas Szepe <szepe@pinerecords.com>


diff -urN a/fs/Kconfig b/fs/Kconfig
--- a/fs/Kconfig	2003-06-14 23:07:12.000000000 +0200
+++ b/fs/Kconfig	2003-07-26 20:48:56.000000000 +0200
@@ -481,7 +481,11 @@
 	  local network, you probably do not need an automounter, and can say
 	  N here.
 
-menu "CD-ROM/DVD Filesystems"
+config CD_FS
+	bool "CD-ROM/DVD Filesystems"
+	default y
+
+if CD_FS
 
 config ISO9660_FS
 	tristate "ISO 9660 CDROM file system support"
@@ -545,9 +549,13 @@
 
 	  If unsure, say N.
 
-endmenu
+endif
+
+config MS_FS
+	bool "DOS/FAT/NT Filesystems"
+	default y
 
-menu "DOS/FAT/NT Filesystems"
+if MS_FS
 
 config FAT_FS
 	tristate "DOS FAT fs support"
@@ -728,9 +736,13 @@
 
 	  It is strongly recommended and perfectly safe to say N here.
 
-endmenu
+endif
+
+config PSEUDO_FS
+	bool "Pseudo filesystems"
+	default y
 
-menu "Pseudo filesystems"
+if PSEUDO_FS
 
 config PROC_FS
 	bool "/proc file system support"
@@ -881,9 +893,13 @@
 	  say M here and read <file:Documentation/modules.txt>.  The module
 	  will be called ramfs.
 
-endmenu
+endif
+
+config MISC_FS
+	bool "Miscellaneous filesystems"
+	default y
 
-menu "Miscellaneous filesystems"
+if MISC_FS
 
 config ADFS_FS
 	tristate "ADFS file system support (EXPERIMENTAL)"
@@ -1261,10 +1277,14 @@
 	  Say Y here if you want to try writing to UFS partitions. This is
 	  experimental, so you should back up your UFS partitions beforehand.
 
-endmenu
+endif
 
-menu "Network File Systems"
+config NET_FS
+	bool "Network File Systems"
 	depends on NET
+	default y
+
+if NET_FS
 
 config NFS_FS
 	tristate "NFS file system support"
@@ -1591,7 +1611,7 @@
 	default m if AFS_FS=m
 	default y if AFS_FS=y
 
-endmenu
+endif
 
 menu "Partition Types"
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [TRIVIAL] kill annoying submenus in fs/Kconfig
  2003-07-27  3:09 ` Randy.Dunlap
@ 2003-07-27  7:02   ` Tomas Szepe
  0 siblings, 0 replies; 4+ messages in thread
From: Tomas Szepe @ 2003-07-27  7:02 UTC (permalink / raw)
  To: Randy.Dunlap; +Cc: torvalds, linux-kernel

> [rddunlap@osdl.org]
> 
> On Sat, 26 Jul 2003 21:55:44 +0200 Tomas Szepe <szepe@pinerecords.com> wrote:
> 
> | Patch against -bk3.
>
> Let me begin by saying that I find the menu arrangement (both before
> and after this patch) highly subjective.

I guess so.

> I.e., there's not necessarily a right or wrong. (RR:)
> I.e., in the absence of further input, some maintainer can decide.  :)
> 
> Given the above:
> I prefer short menus.  I find them more readable, with less clutter.
> So I don't mind them the way that they currently are.
> 
> OTOH, I don't care strongly either way.  I think that we should
> care more about how non-developers use and see 'make *config'
> than how kernel developers use and see it.

I can't see why we need to categorize ~50 (that is _two_ 80x25 screenfuls)
filesystems into 7 or so submenus.  The going back and forth in menuconfig
just to check if NFS and proc are enabled for a basic config is highly
annoying IMHO.  The categorization itself is a nice idea, though.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [TRIVIAL] kill annoying submenus in fs/Kconfig
  2003-07-26 19:55 Tomas Szepe
@ 2003-07-27  3:09 ` Randy.Dunlap
  2003-07-27  7:02   ` Tomas Szepe
  0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2003-07-27  3:09 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: torvalds, linux-kernel

On Sat, 26 Jul 2003 21:55:44 +0200 Tomas Szepe <szepe@pinerecords.com> wrote:

| Patch against -bk3.
| 
| -- 

Let me begin by saying that I find the menu arrangement (both before
and after this patch) highly subjective.

I.e., there's not necessarily a right or wrong. (RR:)
I.e., in the absence of further input, some maintainer can decide.  :)

Given the above:
I prefer short menus.  I find them more readable, with less clutter.
So I don't mind them the way that they currently are.

OTOH, I don't care strongly either way.  I think that we should
care more about how non-developers use and see 'make *config'
than how kernel developers use and see it.


--
~Randy
| http://developer.osdl.org/rddunlap/ | http://www.xenotime.net/linux/ |
For Linux-2.6:
http://www.codemonkey.org.uk/post-halloween-2.5.txt
  or http://lwn.net/Articles/39901/
http://www.kernel.org/pub/linux/kernel/people/rusty/modules/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [TRIVIAL] kill annoying submenus in fs/Kconfig
@ 2003-07-26 19:55 Tomas Szepe
  2003-07-27  3:09 ` Randy.Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Tomas Szepe @ 2003-07-26 19:55 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: lkml

Patch against -bk3.

-- 
Tomas Szepe <szepe@pinerecords.com>


diff -urN a/fs/Kconfig b/fs/Kconfig
--- a/fs/Kconfig	2003-06-14 23:07:12.000000000 +0200
+++ b/fs/Kconfig	2003-07-26 20:48:56.000000000 +0200
@@ -481,7 +481,11 @@
 	  local network, you probably do not need an automounter, and can say
 	  N here.
 
-menu "CD-ROM/DVD Filesystems"
+config CD_FS
+	bool "CD-ROM/DVD Filesystems"
+	default y
+
+if CD_FS
 
 config ISO9660_FS
 	tristate "ISO 9660 CDROM file system support"
@@ -545,9 +549,13 @@
 
 	  If unsure, say N.
 
-endmenu
+endif
+
+config MS_FS
+	bool "DOS/FAT/NT Filesystems"
+	default y
 
-menu "DOS/FAT/NT Filesystems"
+if MS_FS
 
 config FAT_FS
 	tristate "DOS FAT fs support"
@@ -728,9 +736,13 @@
 
 	  It is strongly recommended and perfectly safe to say N here.
 
-endmenu
+endif
+
+config PSEUDO_FS
+	bool "Pseudo filesystems"
+	default y
 
-menu "Pseudo filesystems"
+if PSEUDO_FS
 
 config PROC_FS
 	bool "/proc file system support"
@@ -881,9 +893,13 @@
 	  say M here and read <file:Documentation/modules.txt>.  The module
 	  will be called ramfs.
 
-endmenu
+endif
+
+config MISC_FS
+	bool "Miscellaneous filesystems"
+	default y
 
-menu "Miscellaneous filesystems"
+if MISC_FS
 
 config ADFS_FS
 	tristate "ADFS file system support (EXPERIMENTAL)"
@@ -1261,10 +1277,14 @@
 	  Say Y here if you want to try writing to UFS partitions. This is
 	  experimental, so you should back up your UFS partitions beforehand.
 
-endmenu
+endif
 
-menu "Network File Systems"
+config NET_FS
+	bool "Network File Systems"
 	depends on NET
+	default y
+
+if NET_FS
 
 config NFS_FS
 	tristate "NFS file system support"
@@ -1591,7 +1611,7 @@
 	default m if AFS_FS=m
 	default y if AFS_FS=y
 
-endmenu
+endif
 
 menu "Partition Types"
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-08-05  7:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-05  7:27 [TRIVIAL] kill annoying submenus in fs/Kconfig Tomas Szepe
  -- strict thread matches above, loose matches on Subject: below --
2003-07-26 19:55 Tomas Szepe
2003-07-27  3:09 ` Randy.Dunlap
2003-07-27  7:02   ` Tomas Szepe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).