From: Pavel Machek <pavel@ucw.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PM] save/restore screen support for ACPI S3 sleep
Date: Tue, 5 Aug 2003 11:17:34 +0200 [thread overview]
Message-ID: <20030805091734.GE388@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0308041800461.23977-100000@cherise>
Hi!
> > This way console should be correctly restored after S3...
> >
> > [Prototype should be added to include/linux/suspend.h].
> >
> > kernel/suspend.c part only moves code out of "SWSUSP_ONLY"
> > section.
>
> I moved this code to kernel/power/console.c and made it dependent on
> CONFIG_PM only. I also fixed up the breakage Andrew reported earlier and
> added prototypes to include/linux/suspend.h. Patch below for review (not
> directly applicable, as it's relative to the series).
Patch looks good, except that you should put some comment at begining
of console.c. (GPL+copyrights+one line what this file is about). I
guess that's trivial to fix up incrementally.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-08-05 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-26 22:56 [PM] save/restore screen support for ACPI S3 sleep Pavel Machek
2003-08-05 1:03 ` Patrick Mochel
2003-08-05 9:17 ` Pavel Machek [this message]
2003-08-05 15:57 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030805091734.GE388@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).