[PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Marc-Christian Petersen]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Hi Marcelo,

$subject says it all.

Please apply for 2.4.22-pre10. Thank you :)

ciao, Marc

[-- Attachment #2: 2.4-SAK-info.patch --]
[-- Type: text/x-diff, Size: 698 bytes --]

--- a/drivers/char/tty_io.c	Fri Jan 25 15:49:44 2002
+++ b/drivers/char/tty_io.c	Tue Mar 19 08:28:27 2002
@@ -1888,6 +1888,9 @@
	for_each_task(p) {
		if ((p->tty == tty) ||
		    ((session > 0) && (p->session == session))) {
+				printk(KERN_NOTICE "SAK: killed process %d"
+				" (%s): p->session==tty->session\n",
+				p->pid, p->comm);
			send_sig(SIGKILL, p, 1);
			continue;
		}
@@ -1898,6 +1898,9 @@
				filp = fcheck_files(p->files, i);
				if (filp && (filp->f_op == &tty_fops) &&
				    (filp->private_data == tty)) {
+						printk(KERN_NOTICE "SAK: killed process %d"
+						" (%s): fd#%d opened to the tty\n",
+						p->pid, p->comm, i);
					send_sig(SIGKILL, p, 1);
					break;
				}

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Alan Cox]

On Gwe, 2003-08-01 at 11:40, Marc-Christian Petersen wrote:
> Hi Marcelo,
> 
> $subject says it all.
> 
> Please apply for 2.4.22-pre10. Thank you :)
> 
> ciao, Marc

This is potentially private information. It shouldnt be reported
I disagree with the patch

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Marc-Christian Petersen]

On Friday 01 August 2003 14:09, Alan Cox wrote:

Hi Alan,

> This is potentially private information. It shouldnt be reported
> I disagree with the patch
well, it get logged to syslog(3) and dmesg(8). No normal user has access to 
it, no?

ciao, Marc

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Marc-Christian Petersen]

On Friday 01 August 2003 14:26, Marc-Christian Petersen wrote:

Hi Alan,

> well, it get logged to syslog(3) and dmesg(8). No normal user has access to
> it, no?
forget it. Mainline kernels give the normal user access to dmesg :)

ciao, Marc

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Alan Cox]

On Gwe, 2003-08-01 at 13:26, Marc-Christian Petersen wrote:
> On Friday 01 August 2003 14:09, Alan Cox wrote:
> 
> Hi Alan,
> 
> > This is potentially private information. It shouldnt be reported
> > I disagree with the patch
> well, it get logged to syslog(3) and dmesg(8). No normal user has access to 
> it, no?

It may also end up on the console

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Pavel Machek]

Hi!

> > $subject says it all.
> > 
> > Please apply for 2.4.22-pre10. Thank you :)
> > 
> > ciao, Marc
> 
> This is potentially private information. It shouldnt be reported
> I disagree with the patch

I agree it is not good enough for 2.4.X, but it looks good to me for
2.6. That information can be get by ps, right? If we decide it is not
okay to print process names to syslog, maybe oom killer should be
fixed, too?
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Alan Cox]

On Maw, 2003-08-05 at 11:59, Pavel Machek wrote:
> I agree it is not good enough for 2.4.X, but it looks good to me for
> 2.6. That information can be get by ps, right? If we decide it is not
> okay to print process names to syslog, maybe oom killer should be
> fixed, too?

SAK allows me to see what was running without having an account on the box

Re: [PATCH 2.4.22-pre10] SAK: If a process is killed by SAK, give us an info about which one was killed

[Pavel Machek]

Hi!
> > I agree it is not good enough for 2.4.X, but it looks good to me for
> > 2.6. That information can be get by ps, right? If we decide it is not
> > okay to print process names to syslog, maybe oom killer should be
> > fixed, too?
> 
> SAK allows me to see what was running without having an account on the box

Hmm, but current situation in such case is an admin with some dead processes and no idea
what went wrong :-(
-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...