Re: 2.5/2.6 PCMCIA Issues

[Adam Belay <ambx1@neo.rr.com>]

On Tue, Aug 05, 2003 at 10:59:43PM -0700, OSDL wrote:
> Misha Nasledov wrote:
> > 
> > I am attaching the dmesg output after booting 2.6.0-test2; this does
> > not include the insertion of the Orinoco card as the console freezes
> > immediately after the event. I inspected my logs after a reboot and
> > there were no messages whatsoever regarding the event of the insertion
> > of the Orinoco card.
> 
> Can you try with PnP and the i82365 support _disabled_. I find this sequence
> very suspicious:
> 
>         Intel PCIC probe: PNP <6>pnp: Device 00:17 activated.
>         invalid resources ?
>         pnp: Device 00:17 disabled.
>         not found.

Here's a quick fix that will at least correct the i82365 probing.  It will
be interesting to see what effect it has on these other problems.  Note
that this driver needs some work with check_region etc.

[PCMCIA] Fix PnP Probing in i82365.c
pnp_x_valid returns 1 if valid.  Therefore we should be using !pnp_port_valid.
Also cleans up some formatting issues.

--- a/drivers/pcmcia/i82365.c	2003-07-27 17:08:32.000000000 +0000
+++ b/drivers/pcmcia/i82365.c	2003-08-06 11:18:21.000000000 +0000
@@ -795,16 +795,14 @@

 	    if (pnp_device_attach(dev) < 0)
 	    	continue;
-
-	    printk("PNP ");
-
+
 	    if (pnp_activate_dev(dev) < 0) {
 		printk("activate failed\n");
 		pnp_device_detach(dev);
 		break;
 	    }

-	    if (pnp_port_valid(dev, 0)) {
+	    if (!pnp_port_valid(dev, 0)) {
 		printk("invalid resources ?\n");
 		pnp_device_detach(dev);
 		break;


> 
> and I bet it messes up some of the register state that the yenta probe had
> just set up.
> 
> You should try with just CONFIG_YENTA - the 82365 stuff is for the old
> 16-bit only controllers.
> 
>                 Linus

Thanks,
Adam