From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270984AbTHFTbF (ORCPT ); Wed, 6 Aug 2003 15:31:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270971AbTHFTbF (ORCPT ); Wed, 6 Aug 2003 15:31:05 -0400 Received: from codepoet.org ([166.70.99.138]:7900 "EHLO winder.codepoet.org") by vger.kernel.org with ESMTP id S270984AbTHFTbA (ORCPT ); Wed, 6 Aug 2003 15:31:00 -0400 Date: Wed, 6 Aug 2003 13:30:58 -0600 From: Erik Andersen To: Bartlomiej Zolnierkiewicz Cc: Andries Brouwer , Alan Cox , Marcelo Tosatti , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE Message-ID: <20030806193058.GA27207@codepoet.org> Reply-To: andersen@codepoet.org Mail-Followup-To: Erik Andersen , Bartlomiej Zolnierkiewicz , Andries Brouwer , Alan Cox , Marcelo Tosatti , linux-kernel@vger.kernel.org References: <20030806181142.GD25910@codepoet.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Operating-System: Linux 2.4.19-rmk7, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips X-No-Junk-Mail: I do not want to get *any* junk mail. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed Aug 06, 2003 at 08:32:23PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Wed, 6 Aug 2003, Erik Andersen wrote: > > > > Can you please resend me the patch once its accepted in 2.6 ? > > > > > > Maybe we want to test it a while in -ac, also? > > > > Ok. Though it is being incorporated as part of a much larger > > patch in 2.6. I suppose that will filter back into 2.4 when > > it is ready, > > Hi Erik, > > I made init_idedisk_capacity() cleanup. > Then I ported your patch and reworked it a bit. > > Could you take a look? I like your improvements. The only concern I have is you retained my use of do_div() intact. That needs to change since it turns out that do_div() directly modifies the numerator (violating the principle of least surprise). See the recent thread on "do_div considered harmful". In that thread, Andries mentions he has made a generic sectors_to_MB() function to consolidate such things. which I think is a very good idea since then this only has to be correct once. That would also let you eliminate the somewhat ugly and not particularly obvious division plus rounding (X - X/625 + 974)/1950 sequence from idedisk_check_hpa_lba28(), -Erik -- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons--