From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271159AbTHLVgd (ORCPT ); Tue, 12 Aug 2003 17:36:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271156AbTHLVgd (ORCPT ); Tue, 12 Aug 2003 17:36:33 -0400 Received: from mail.kroah.org ([65.200.24.183]:3279 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S271155AbTHLVga (ORCPT ); Tue, 12 Aug 2003 17:36:30 -0400 Date: Tue, 12 Aug 2003 14:35:49 -0700 From: Greg KH To: Christoph Hellwig , Andries Brouwer , linux-scsi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [linux-usb-devel] Re: [PATCH] oops in sd_shutdown Message-ID: <20030812213549.GA2158@kroah.com> References: <20030812002844.B1353@pclin040.win.tue.nl> <20030812075353.A18547@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030812075353.A18547@infradead.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 12, 2003 at 07:53:53AM +0100, Christoph Hellwig wrote: > On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote: > > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL > > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set > > in sd_probe. But in my case sd_probe never finished. An insmod usb-storage > > hangs forever, or at least for more than six hours, giving ample opportunity > > to observe this race between sd_probe and sd_shutdown. > > (Of course sd_probe hangs in sd_revalidate disk.) > > Well, this same problem could show upb in any other driver. Could > you instead send a patch to Pat that the driver model never calls > the shutdown method for a driver that hasn't finished ->probe? I think it already will not do that due to taking the bus->subsys.rwsem before calling either probe() or remove(). thanks, greg k-h