From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: torvalds@osdl.org
Subject: Re: Fix up riscom8 driver to use work queues instead of task queueing.
Date: Mon, 18 Aug 2003 14:09:41 -0400 [thread overview]
Message-ID: <20030818180941.GJ24693@gtf.org> (raw)
In-Reply-To: <200308181806.h7II6K6D014918@hera.kernel.org>
On Mon, Aug 18, 2003 at 04:59:53PM +0000, Linux Kernel Mailing List wrote:
> @@ -425,7 +414,7 @@
>
> *tty->flip.char_buf_ptr++ = ch;
> tty->flip.count++;
> - queue_task(&tty->flip.tqueue, &tq_timer);
> + schedule_delayed_work(&tty->flip.work, 1);
> }
>
> static inline void rc_receive(struct riscom_board const * bp)
> @@ -456,7 +445,7 @@
> *tty->flip.flag_buf_ptr++ = 0;
> tty->flip.count++;
> }
> - queue_task(&tty->flip.tqueue, &tq_timer);
> + schedule_delayed_work(&tty->flip.work, 1);
> }
>
> static inline void rc_transmit(struct riscom_board const * bp)
Should we just make schedule_delayed_work(foo, 1) the default for a
schedule_work() call?
I'm seeing this construct pop up more and more... and would rather have
it fixed at the source, not in every driver.
Jeff
next parent reply other threads:[~2003-08-18 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200308181806.h7II6K6D014918@hera.kernel.org>
2003-08-18 18:09 ` Jeff Garzik [this message]
2003-08-18 18:21 ` Fix up riscom8 driver to use work queues instead of task queueing Linus Torvalds
2003-08-18 18:28 ` Russell King
2003-08-18 18:47 ` Linus Torvalds
2003-08-18 18:59 ` Russell King
2003-08-18 19:10 ` Linus Torvalds
2003-08-18 18:44 ` Jeff Garzik
2003-08-18 19:12 ` Linus Torvalds
2003-08-18 19:25 ` Jeff Garzik
2003-08-18 19:36 ` Linus Torvalds
2003-08-18 20:32 ` Andrew Morton
2003-08-18 21:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030818180941.GJ24693@gtf.org \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).