linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Phil Oester <kernel@theoesters.com>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH] Ratelimit SO_BSDCOMPAT warnings
Date: Mon, 18 Aug 2003 18:15:40 -0400	[thread overview]
Message-ID: <200308182215.h7IMFecc013449@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 18 Aug 2003 15:06:05 PDT." <20030818150605.A23957@ns1.theoesters.com>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Mon, 18 Aug 2003 15:06:05 PDT, Phil Oester said:
> Back in March, there was some discussion about ratelimiting the
> BSDCOMPAT errors, and James Morris provided a patch to achieve
> this.

> Unfortunately, it seems to have fallen through the cracks.  Below
> is the patch again, updated for 2.6.0-test3 - please apply.

>  static void sock_warn_obsolete_bsdism(const char *name)
>  {
> -       printk(KERN_WARNING "process `%s' is using obsolete "
> -              "%s SO_BSDCOMPAT\n", current->comm, name);
> +       static int warned;
> +
> +       if (!warned) {
> +               warned = 1;


Umm.. am I dense, or does this only warn once for *the first program*
to do it after the system boots?  And you don't get another warning about
any OTHER programs until you reboot in a few weeks (possibly)?

If so, why are we bothering at all?  Once *per process* I could see, but
once per boot?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  reply	other threads:[~2003-08-18 22:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-18 22:06 [PATCH] Ratelimit SO_BSDCOMPAT warnings Phil Oester
2003-08-18 22:15 ` Valdis.Kletnieks [this message]
2003-08-18 22:48   ` David S. Miller
2003-08-19  0:36     ` Jamie Lokier
2003-08-19  1:05       ` Jamie Lokier
2003-08-19 14:32         ` Phil Oester
2003-08-19  0:37   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200308182215.h7IMFecc013449@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=kernel@theoesters.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).