From: William Lee Irwin III <firstname.lastname@example.org> To: Andi Kleen <email@example.com> Cc: Mikael Pettersson <firstname.lastname@example.org>, email@example.com Subject: Re: [BUG][2.6.0-test3-bk7] x86-64 UP_IOAPIC panic caused by cpumask_t conversion Date: Tue, 19 Aug 2003 16:51:26 -0700 [thread overview] Message-ID: <20030819235126.GC4306@holomorphy.com> (raw) In-Reply-To: <firstname.lastname@example.org> Mikael Pettersson <email@example.com> writes: > Nasty. > But why does i386/UP work? On Wed, Aug 20, 2003 at 01:39:10AM +0200, Andi Kleen wrote: > > (I believe this is the correct thing to do, except having > > CONFIG_X86_IO_APIC in generic code isn't quite right.) > Better would be to undo the cpumask_t changes in io_apic.c > and go back to unsigned long masks there again. > Obviously a cpu mask is not the right data structure to manage APICs > Another way would be to do whatever i386 does to avoid the problem. > The IO-APIC code is unfortunately quite out of date/unsynced compared to i386, > maybe it just needs some bug fix ported over. I will check that later. Odd; I have a UP IO-APIC ia32 box here and it appears to do okay; there is a question of sparse APIC ID's and APIC ID space needing to be independent of NR_CPUS handled in the ia32 code that isn't handled in the x86_64 code. It was handled for ia32 by using a bitmap of size MAX_APICS (physid_mask_t) instead of cpumask_t for the things, which appears to eliminate various special cases for xAPIC's too. -- wli
next prev parent reply other threads:[~2003-08-19 23:50 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <mnCB.firstname.lastname@example.org> 2003-08-19 23:39 ` Andi Kleen 2003-08-19 23:51 ` William Lee Irwin III [this message] 2003-08-19 23:57 ` Andi Kleen 2003-08-20 0:39 ` [PATCH] physid_maskt for x86-64 was R[BUG][2.6.0-test3-bk7] " Andi Kleen 2003-08-19 22:57 [BUG][2.6.0-test3-bk7] " Mikael Pettersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030819235126.GC4306@holomorphy.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [BUG][2.6.0-test3-bk7] x86-64 UP_IOAPIC panic caused by cpumask_t conversion' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).