linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH-2.6.0-test4-bk1][stallion.c]Remaining task queue to work queue conversion.
@ 2003-08-24 12:48 Krishnakumar. R
  0 siblings, 0 replies; only message in thread
From: Krishnakumar. R @ 2003-08-24 12:48 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel

Dear Linus and all,

Somewhere in the transition of task queue to the work queue,
in stallion.c, some of the schedule_task were
left out from being converted to schedule_work.
The following patch solves the problem.

Without this the drivers/char/stallion.c 
cannot be compiled as part of the kernel (make bzImage).

Please do apply!

Regards
KK

============================
The following is the patch:

--- linux-2.6.0-test4-bk1/drivers/char/stallion.orig.c	2003-08-23 05:28:12.000000000 +0530
+++ linux-2.6.0-test4-bk1/drivers/char/stallion.c	2003-08-24 18:09:23.000000000 +0530
@@ -4234,7 +4234,7 @@
 	misr = inb(ioaddr + EREG_DATA);
 	if (misr & MISR_DCD) {
 		set_bit(ASYI_DCDCHANGE, &portp->istate);
-		schedule_task(&portp->tqueue);
+		schedule_work(&portp->tqueue);
 		portp->stats.modem++;
 	}
 
@@ -5031,7 +5031,7 @@
 	if ((len == 0) || ((len < STL_TXBUFLOW) &&
 	    (test_bit(ASYI_TXLOW, &portp->istate) == 0))) {
 		set_bit(ASYI_TXLOW, &portp->istate);
-		schedule_task(&portp->tqueue); 
+		schedule_work(&portp->tqueue); 
 	}
 
 	if (len == 0) {
@@ -5248,7 +5248,7 @@
 		ipr = stl_sc26198getreg(portp, IPR);
 		if (ipr & IPR_DCDCHANGE) {
 			set_bit(ASYI_DCDCHANGE, &portp->istate);
-			schedule_task(&portp->tqueue); 
+			schedule_work(&portp->tqueue); 
 			portp->stats.modem++;
 		}
 		break;


===============================
diffstat output:
stallion.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
===============================
Compiliation errors removed:
drivers/char/stallion.c: In function `stl_cd1400mdmisr':
drivers/char/stallion.c:4237: warning: implicit declaration of function `schedule_task'
================================
Linking errors removed:
drivers/built-in.o(.text+0x400ae): In function `stl_cd1400mdmisr':
: undefined reference to `schedule_task'
drivers/built-in.o(.text+0x41218): In function `stl_sc26198txisr':
: undefined reference to `schedule_task'
drivers/built-in.o(.text+0x41699): In function `stl_sc26198otherisr':
: undefined reference to `schedule_task'
make: *** [.tmp_vmlinux1] Error 1
=================================


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-08-24 12:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-24 12:48 [PATCH-2.6.0-test4-bk1][stallion.c]Remaining task queue to work queue conversion Krishnakumar. R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).