* [patch 2.6] 3c509.c Fix printed dev id.
@ 2003-08-25 3:27 Paul
0 siblings, 0 replies; only message in thread
From: Paul @ 2003-08-25 3:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Jeff Garzik, Andrew Morton
Hi;
Callers of el3_common_init() immeadiately then call
register_netdev() and check it for error, and on error
call release_region() on the io addr, and follow an error
path.
As it stands, the detection prink in el3_common_init()
prints out something like:
eth%d: 3c5x9 at 0x280, BNC port, address 00 20 af 2f d4 81, IRQ 5.
^^
Because the %d is filled out by register_netdev(), called
after the printk.
This patch just moves all the register_netdev(), and the
release_region() (on error) inside of el3_common_init(), and
gives that function a return value. Now the prink will identify
the device name assigned. Behaviour on error should be
functionally unchanged.
Paul
set@pobox.com
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-08-25 3:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-25 3:27 [patch 2.6] 3c509.c Fix printed dev id Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).