linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Willy Tarreau <willy@w.ods.org>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [AMD76X]
Date: Mon, 25 Aug 2003 18:12:41 +1000	[thread overview]
Message-ID: <20030825081241.GA6538@gondor.apana.org.au> (raw)
In-Reply-To: <20030824175321.GF734@alpha.home.local>

On Sun, Aug 24, 2003 at 07:53:21PM +0200, Willy Tarreau wrote:
> 
> I'm wondering whether this patch should be needed too.
> 
> --- linux-2.4.22-rc3/drivers/char/amd76x_pm.c.orig	Sun Aug 24 19:52:42 2003
> +++ linux-2.4.22-rc3/drivers/char/amd76x_pm.c	Sun Aug 24 19:53:49 2003
> @@ -620,6 +620,8 @@
>  #ifndef AMD76X_NTH
>  	if (!amd76x_pm_cfg.curr_idle) {
>  		printk(KERN_ERR "amd76x_pm: Idle function not changed\n");
> +		pci_unregister_driver(&amd_nb_driver);
> +		pci_unregister_driver(&amd_sb_driver);
>  		return 1;
>  	}

Although this error is currently not possible, we should include
your fixup anyway.

Thanks,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2003-08-25  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-23 23:33 [AMD76X] Herbert Xu
2003-08-24 17:53 ` [AMD76X] Willy Tarreau
2003-08-25  8:12   ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030825081241.GA6538@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=willy@w.ods.org \
    --subject='Re: [AMD76X]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).