From: insecure <insecure@mail.od.ua>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix ide unregister vs. driver model
Date: Mon, 25 Aug 2003 13:01:00 +0300 [thread overview]
Message-ID: <200308251301.00267.insecure@mail.od.ua> (raw)
In-Reply-To: <1061730317.31688.10.camel@gaston>
On Sunday 24 August 2003 16:05, Benjamin Herrenschmidt wrote:
> static void hwif_register (ide_hwif_t *hwif)
> {
> /* register with global device tree */
> strlcpy(hwif->gendev.bus_id,hwif->name,BUS_ID_SIZE);
> hwif->gendev.driver_data = hwif;
> + if (hwif->gendev.parent == NULL) {
> if (hwif->pci_dev)
> hwif->gendev.parent = &hwif->pci_dev->dev;
> else
> hwif->gendev.parent = NULL; /* Would like to do = &device_legacy */
> + }
inner if() should be indented
--
vda
next prev parent reply other threads:[~2003-08-25 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-24 13:05 [PATCH] Fix ide unregister vs. driver model Benjamin Herrenschmidt
2003-08-24 22:23 ` Bartlomiej Zolnierkiewicz
2003-08-25 6:34 ` Benjamin Herrenschmidt
2003-08-25 20:50 ` Bartlomiej Zolnierkiewicz
2003-08-25 20:54 ` viro
2003-08-25 20:59 ` Patrick Mochel
2003-08-25 21:06 ` Bartlomiej Zolnierkiewicz
2003-08-25 10:01 ` insecure [this message]
2003-08-25 10:04 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308251301.00267.insecure@mail.od.ua \
--to=insecure@mail.od.ua \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).