linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: insecure <insecure@mail.od.ua>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] raceless request_region() fix (was Re: Linux 2.6.0-test4)
Date: Tue, 26 Aug 2003 08:20:13 +0300	[thread overview]
Message-ID: <200308260820.13205.insecure@mail.od.ua> (raw)
In-Reply-To: <3F4A86B8.9080404@pobox.com>

[de-cc'ing Linus]

On Tuesday 26 August 2003 00:59, Jeff Garzik wrote:
> Is it a race if noone cares?  :)
>
> The code does
>
> 	if (!request_region(...))
> 		fail
> 	touch hardware
> 	release_region
> 	if (!request_region(...))
> 		fail
>
> If the HIGHLY UNLIKELY event of another ISA driver claiming this region
> occurs, the system continues working just fine.

Yes, this particular driver is fine. My patch just eliminate back-to-back
 	release_region(...)
 	if (!request_region(...)) fail;
pair.

I just have a feeling that if I am going to replace check_region with
request_region, I can close race window altogether.

BTW, it all started when I tried to get rid of check_region in de4x5.c.
That's a bit worse. For example:
        barrier();
        request_region(iobase, (lp->bus == PCI ? DE4X5_PCI_TOTAL_SIZE :
                                DE4X5_EISA_TOTAL_SIZE),
                       lp->adapter_name);
        lp->rxRingSize = NUM_RX_DESC;
-- 
vda

  reply	other threads:[~2003-08-26  5:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-23  0:48 Linux 2.6.0-test4 Linus Torvalds
2003-08-23  1:21 ` [PATCH] Fix cdrom error handling in 2.6 Erik Andersen
2003-08-23 12:26 ` Linux 2.6.0-test4 vlad
2003-08-23 15:31   ` Jeff Garzik
2003-08-23 15:33     ` William Scott Lockwood III
2003-08-25  5:43     ` vlad
2003-08-24 11:39 ` [PATCH] airo (was: Re: Linux 2.6.0-test4) Geert Uytterhoeven
2003-08-24 21:00   ` Javier Achirica
2003-08-24 11:47 ` [PATCH] vmlinux-*.lds " Geert Uytterhoeven
2003-08-24 11:51 ` [PATCH] macide " Geert Uytterhoeven
2003-08-24 12:20   ` Christoph Hellwig
2003-08-24 12:29     ` Geert Uytterhoeven
2003-08-25 21:00 ` [patch] 2.6.0-test4: sis190 doesn't compile with gcc 2.95 Adrian Bunk
2003-08-26 17:44   ` Jeff Garzik
2003-08-25 21:20 ` Linux 2.6.0-test4 insecure
2003-08-25 21:26   ` [PATCH] raceless request_region() fix (was Re: Linux 2.6.0-test4) insecure
2003-08-25 21:59     ` Jeff Garzik
2003-08-26  5:20       ` insecure [this message]
2003-08-25 22:56 ` Linux 2.6.0-test4 (compile statistics) John Cherry
2003-08-30  9:04 ` Linux 2.6.0-test4 Ralf Hildebrandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200308260820.13205.insecure@mail.od.ua \
    --to=insecure@mail.od.ua \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] raceless request_region() fix (was Re: Linux 2.6.0-test4)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).