* [PATCH] fb_cmap and transparency
@ 2003-08-29 14:49 Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2003-08-29 14:49 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Linux Fbdev, Linux Kernel Development, Geert Uytterhoeven
If a colormap contains no transparency information, fb_set_cmap() calls
fb_setcolreg() with trans = 0. This causes all CLUT entries to be fully
transparent on hardware that does have transparency information in the CLUT
registers.
The following patch solves this problem by changing the default transparency
from 0 (full transparent) to 0xffff (full opaque).
--- linux-2.4.23-pre1/drivers/video/fbcmap.c.orig Mon Mar 5 09:29:30 2001
+++ linux-2.4.23-pre1/drivers/video/fbcmap.c Mon Mar 17 17:39:59 2003
@@ -271,7 +271,7 @@
hred = *red;
hgreen = *green;
hblue = *blue;
- htransp = transp ? *transp : 0;
+ htransp = transp ? *transp : 0xffff;
} else {
get_user(hred, red);
get_user(hgreen, green);
@@ -279,7 +279,7 @@
if (transp)
get_user(htransp, transp);
else
- htransp = 0;
+ htransp = 0xffff;
}
red++;
green++;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] fb_cmap and transparency
@ 2003-06-15 19:10 Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2003-06-15 19:10 UTC (permalink / raw)
To: Marcelo Tosatti, Alan Cox
Cc: Linux Fbdev, Linux Kernel Development, Geert Uytterhoeven
If a colormap contains no transparency information, fb_set_cmap() calls
fb_setcolreg() with trans = 0. This causes all CLUT entries to be fully
transparent on hardware that does have transparency information in the CLUT
registers.
The following patch solves this problem by changing the default transparency
from 0 (full transparent) to 0xffff (full opaque).
--- linux-2.4.x/drivers/video/fbcmap.c.orig Mon Mar 5 09:29:30 2001
+++ linux-2.4.x/drivers/video/fbcmap.c Mon Mar 17 17:39:59 2003
@@ -271,7 +271,7 @@
hred = *red;
hgreen = *green;
hblue = *blue;
- htransp = transp ? *transp : 0;
+ htransp = transp ? *transp : 0xffff;
} else {
get_user(hred, red);
get_user(hgreen, green);
@@ -279,7 +279,7 @@
if (transp)
get_user(htransp, transp);
else
- htransp = 0;
+ htransp = 0xffff;
}
red++;
green++;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-29 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-29 14:49 [PATCH] fb_cmap and transparency Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2003-06-15 19:10 Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).