linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Linux 2.4.23-pre2
@ 2003-08-30 15:48 Marcelo Tosatti
  2003-08-30 16:22 ` Dave Bentham
                   ` (7 more replies)
  0 siblings, 8 replies; 28+ messages in thread
From: Marcelo Tosatti @ 2003-08-30 15:48 UTC (permalink / raw)
  To: lkml


Hello,

Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
changes from Alan, network drivers update from Jeff, amongst other fixes
and updates.



Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
============================================

<cw:sgi.com>:
  o Add SGI IOC4 IDE Driver
  o SGI SN Serial/Console Driver

<davej:redhat.com>:
  o USB: Add Minolta Dimage F300 to unusual_devs

<gaa:ulticom.com>:
  o USB: new ids for io_ti driver

<javier:tudela.mad.ttd.net>:
  o [wireless airo] add support for MIC and latest firmwares

<kevino:asti-usa.com>:
  o USB: bug in EHCI device reset through transaction

<malte.d:gmx.net>:
  o USB: support for Zaurus 750/760 to usbnet.c (2.4.22-pre8) + code cleanup backport from 2.6

<marcelo:logos.cnet>:
  o Changed hch contact information
  o Fix compilation warning in panic.c
  o Delete unused drivers/scsi/aic79xx (now aic7xxx supports it)
  o add sysctl bits for setuid core
  o Changed EXTRAVERSION to -pre2

<masanari.iida:hp.com>:
  o SCSI blacklist HP Va7140

<mike.miller:hp.com>:
  o cciss multi-path failover in md

<mporter:kernel.crashing.org>:
  o PPC32: Add support for the IBM PPC 440 family of processors
  o PPC32: Add support for DMA controllers on PPC 4xx processors

<russell_d_cagle:mindspring.com>:
  o USB: add Garmin iQue support to visor driver

<thomas:winischhofer.net>:
  o sisfb update

<vmlinuz386:yahoo.com.ar>:
  o PCI Hotplug: fix __FUNCTION__ warnings

Alan Cox:
  o remove all the 440gx broken bios stuff
  o replace the pci router logic with working code
  o update INDEX for docs
  o wolfson touchscreen docs
  o amd watchdog update
  o update i8xx watchdog
  o improved extra key bounce fix
  o fix a missing rocket card
  o warning fix
  o fix nowayout handling on softdog
  o fix missing formatting info in ide-cd
  o add open/close methods to ide-default for hotplug
  o move sibyte driver into the right dir
  o Add Intel ICH3 hotplug support
  o siimage: set a sata flag on the hwif so we can do cable det
  o update ide raid for info pointer changes
  o update ide headers for hotplug
  o fix cable detect issue with sata
  o split ide probe code up
  o Add disk hotplug to the IDE core
  o update cpia driver to fix warnings
  o aacraid update
  o wolfson ac97 touchscreen driver
  o ad1889 error handling fixes
  o ALi5455 update
  o cmpci update
  o fix i810 audio leak
  o makefile/config update for sound changes
  o USB audio fixes for OSS API compliance
  o VGA also works on IA64
  o tdfxfb updates for 24/32 and big endian
  o allow setuid core dumps
  o add sysctl number for setuid core
  o Add headers for wolfson codecs
  o Fix the file sharing/initrd bug
  o resend - mm checks have precedence bugs

Alan Stern:
  o USB: More unusual_devs.h entry updates
  o USB: More unusual_devs.h stuff
  o USB: Another unusual_devs.h entry update

Andrea Arcangeli:
  o vmalloc allocations in ipc needs smp initialized

Andrew Morton:
  o fix possible busywait in rtc_read()
  o tty oops fix

Dan Streetman:
  o USB: backport usbfs 'disconnect'

David Brownell:
  o USB: ehci needs a readb() on IDP425 PCI (ARM)
  o USB: ehci-hcd and period=1frame hs interrupts

David S. Miller:
  o [TG3]: Update to irqreturn_t
  o [TG3]: Sync TSO changes from base 2.5.x
  o [TG3]: Merge comment typo fixes from 2.5.x
  o [TG3]: Initial implementation of 5705 support
  o [TG3]: Fix statistics on 5705
  o [TG3]: Do not reset the RX_MAC unless PHY is Serdes
  o [TG3]: More missing PCI IDs
  o [TG3]: Reset PHY more reliably on 570{3,4,5} chips
  o [TG3]: Fix 5788/5901, update TSO code
  o [TG3]: Differentiate between TSO capable and TSO enabled
  o [TG3]: Add {get,set}_tso ethtool_ops support
  o [TG3]: Bump version/reldate
  o [TG3]: Fix tg3_phy_reset_5703_4_5 chip rev test
  o [TG3]: Bump version/reldate
  o [TG3]: More fixes and enhancements

Geert Uytterhoeven:
  o M68k ptrace
  o Isapnp warning
  o fb_cmap and transparency
  o M68k RTC updates
  o Rename ariadne2 to zorro8390
  o M68k mm cleanup
  o M68k free_io_area()
  o M68k invalid vs. illegal
  o Dmasound invalid vs. illegal
  o M68k cpu_relax()
  o dmasound SOUND_PCM_READ_RATE
  o M68k FPU emulator
  o dmasound core fixes
  o lmc_proto.c includes <asm/smp.h>
  o Sonic Ethernet unsafe interrupt

Greg Kroah-Hartman:
  o USB: added support for TIOCM_RI and TIOCM_CD to pl2303 driver and fix stupid bug
  o USB: remove some vendor specific stuff from the pl2303 driver to get other devices to work
  o [TG3]: pci_device_id can not be marked __devinitdata
  o [netdrvr sis900] don't call pci_find_device from irq context
  o USB: fix up a bunch of copyrights that were incorrectly declared
  o PCI hotplug: fix up a bunch of copyrights that were incorrectly declared
  o PCI: add PCI_DEVICE() macro to make pci_device_id tables easier to read
  o PCI: add PCI_DEVICE_CLASS() macro to match PCI_DEVICE() macro

Henning Meier-Geinitz:
  o USB: New vendor/product ids for scanner driver
  o USB: fix check for SCN_MAX_MNR in scanner driver
  o USB: Fix crash when scanners are disconnected while open
  o USB: unlink interrupt URBs in scanner driver

Hirofumi Ogawa:
  o [netdrvr 8139too] lwake unlock fix
  o [netdrvr 8139too] remove unused RxConfigMask
  o [netdrvr 8139too] add more h/w revision ids

Ian Abbott:
  o USB: ftdi_sio - additional pids
  o USB: ftdi_sio - VID/PID for ID TECH IDT1221U USB to RS-232 adapter
  o USB: ftdi_sio - tidy up write bulk callback

James Morris:
  o [TG3]: skb_headlen() cleanup

Jeff Garzik:
  o [TG3]: Detect shared (and screaming) interrupts
  o [TG3]: Convert to using ethtool_ops
  o [TG3]: Bug fixes for 5705 support
  o [TG3]: More 5705 updates
  o [TG3]: More 5705 fixes
  o [TG3]: Another 5705 fix: enable eeprom write prot as needed
  o [TG3]: Only write the on-nic sram addr on non-5705
  o [TG3]: Add 5782 pci id
  o [netdrvr sis900] ethtool_ops support
  o [netdrvr sis900] minor bits from 2.6
  o [netdrvr 8139cp] minor bits from 2.6
  o [netdrvr 8139cp] ethtool_ops support
  o [netdrvr 3c59x] add a piece missed in previous ethtool_ops patch
  o [netdrvr 3c501] ethtool_ops support
  o [netdrvr] ethtool_ops support in 3c503, 3c505, 3c507
  o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
  o [netdrvr pcmcia] ethtool_ops for 3c574, 3c589, aironet4500, axnet
  o [NET] add SET_ETHTOOL_OPS back-compat hook
  o [netdrvr pcmcia] use SET_ETHTOOL_OPS in 3c574, 3c589, aironet4500, and axnet
  o [netdrvr pcmcia] ethtool_ops support for several more pcmcia drivers
  o [netdrvr 8139too] minor bits from 2.6
  o [wireless airo] build fixes
  o [scsi] add SCSI opcodes and SAM status codes to scsi/scsi.h

Judd Montgomery:
  o USB: visor.h[c] USB device IDs documentation

Marc-Christian Petersen:
  o DRM menu the right fix

Matthew Wilcox:
  o [netdrvr 3c59x] ethtool_ops support

Nemosoft Unv.:
  o USB: PWC 8.11

Paul Mackerras:
  o PPC32: Add support for DMA mapping on non-cache-coherent machines
  o PPC32: Add the infrastructure to allow for 64-bit PTEs
  o PPC32: Fix typo in arch/ppc/Makefile
  o PPC32: Use CONFIG_IBM_OPENBIOS instead of CONFIG_TREEBOOT
  o PPC32: Add support for the PPC970 processor
  o PPC32: Minor cleanups and fixes for 4xx/BookE systems
  o PPC32: Restructure signal code, new ucontext structure, add swapcontext syscall
  o PPC32: Implement semtimedop system call

Paul Mundt:
  o Add Paul Mundt to CREDITS

Randy Dunlap:
  o add seq_file "single" interfaces

Stefan Becker:
  o USB: acm.c update for new devices

Stefan Rompf:
  o [netdrvr 8139too] use mii_check_media lib function, instead of homebrew MII bitbanging.

Steven Cole:
  o Add 39 Configure.help texts from -ac tree
  o Add six more Configure.help texts from the -ac tree

Tom Rini:
  o PPC32: Change the default behavior of a kernel with KGDB
  o PPC32: Fix KGDB and userland GDB interactions

Willy Tarreau:
  o Fix log buffer length issues


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: Linux 2.4.23-pre2
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
@ 2003-08-30 16:22 ` Dave Bentham
  2003-08-30 19:35 ` system_lists
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 28+ messages in thread
From: Dave Bentham @ 2003-08-30 16:22 UTC (permalink / raw)
  To: linux-kernel

Last Wednesday I posted here that when mounting /dev/scd0 CDROM
(hdd=ide-scsi) the new kernel 2.4.22 panicked as 2.4.21 did before that.
2.4.20 is fine in this regard. If I remove the 'hdd=ide-scsi' appendage
then my CD is fine.

Someone has also reported his SCSI Megaraid killed the 2.4.22 too,
looking a similar, if not the same, issue.

So far there's been no response.

It looked to me (a layman as far as the kernel software is concerned)
that email's after the 2.4.21 SCSI problem were posted and that the
issue was being looked at and even perhaps fixed. Is it believed to have
been fixed in 2.4.22 (i.e. I've not built my kernel properly) or is it
still a known problem?

Thanks

Dave



On Sat, 30 Aug 2003 12:48:22 -0300 (BRT)
Marcelo Tosatti <marcelo@conectiva.com.br> wrote:

> 
> Hello,
> 
> Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> changes from Alan, network drivers update from Jeff, amongst other
> fixes and updates.
> 
> 
> 
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
> 
> <cw:sgi.com>:
>   o Add SGI IOC4 IDE Driver
>   o SGI SN Serial/Console Driver
> 
> <davej:redhat.com>:
>   o USB: Add Minolta Dimage F300 to unusual_devs
> 
> <gaa:ulticom.com>:
>   o USB: new ids for io_ti driver
> 
> <javier:tudela.mad.ttd.net>:
>   o [wireless airo] add support for MIC and latest firmwares
> 
> <kevino:asti-usa.com>:
>   o USB: bug in EHCI device reset through transaction
> 
> <malte.d:gmx.net>:
>   o USB: support for Zaurus 750/760 to usbnet.c (2.4.22-pre8) + code
>   cleanup backport from 2.6
> 
> <marcelo:logos.cnet>:
>   o Changed hch contact information
>   o Fix compilation warning in panic.c
>   o Delete unused drivers/scsi/aic79xx (now aic7xxx supports it)
>   o add sysctl bits for setuid core
>   o Changed EXTRAVERSION to -pre2
> 
> <masanari.iida:hp.com>:
>   o SCSI blacklist HP Va7140
> 
> <mike.miller:hp.com>:
>   o cciss multi-path failover in md
> 
> <mporter:kernel.crashing.org>:
>   o PPC32: Add support for the IBM PPC 440 family of processors
>   o PPC32: Add support for DMA controllers on PPC 4xx processors
> 
> <russell_d_cagle:mindspring.com>:
>   o USB: add Garmin iQue support to visor driver
> 
> <thomas:winischhofer.net>:
>   o sisfb update
> 
> <vmlinuz386:yahoo.com.ar>:
>   o PCI Hotplug: fix __FUNCTION__ warnings
> 
> Alan Cox:
>   o remove all the 440gx broken bios stuff
>   o replace the pci router logic with working code
>   o update INDEX for docs
>   o wolfson touchscreen docs
>   o amd watchdog update
>   o update i8xx watchdog
>   o improved extra key bounce fix
>   o fix a missing rocket card
>   o warning fix
>   o fix nowayout handling on softdog
>   o fix missing formatting info in ide-cd
>   o add open/close methods to ide-default for hotplug
>   o move sibyte driver into the right dir
>   o Add Intel ICH3 hotplug support
>   o siimage: set a sata flag on the hwif so we can do cable det
>   o update ide raid for info pointer changes
>   o update ide headers for hotplug
>   o fix cable detect issue with sata
>   o split ide probe code up
>   o Add disk hotplug to the IDE core
>   o update cpia driver to fix warnings
>   o aacraid update
>   o wolfson ac97 touchscreen driver
>   o ad1889 error handling fixes
>   o ALi5455 update
>   o cmpci update
>   o fix i810 audio leak
>   o makefile/config update for sound changes
>   o USB audio fixes for OSS API compliance
>   o VGA also works on IA64
>   o tdfxfb updates for 24/32 and big endian
>   o allow setuid core dumps
>   o add sysctl number for setuid core
>   o Add headers for wolfson codecs
>   o Fix the file sharing/initrd bug
>   o resend - mm checks have precedence bugs
> 
> Alan Stern:
>   o USB: More unusual_devs.h entry updates
>   o USB: More unusual_devs.h stuff
>   o USB: Another unusual_devs.h entry update
> 
> Andrea Arcangeli:
>   o vmalloc allocations in ipc needs smp initialized
> 
> Andrew Morton:
>   o fix possible busywait in rtc_read()
>   o tty oops fix
> 
> Dan Streetman:
>   o USB: backport usbfs 'disconnect'
> 
> David Brownell:
>   o USB: ehci needs a readb() on IDP425 PCI (ARM)
>   o USB: ehci-hcd and period=1frame hs interrupts
> 
> David S. Miller:
>   o [TG3]: Update to irqreturn_t
>   o [TG3]: Sync TSO changes from base 2.5.x
>   o [TG3]: Merge comment typo fixes from 2.5.x
>   o [TG3]: Initial implementation of 5705 support
>   o [TG3]: Fix statistics on 5705
>   o [TG3]: Do not reset the RX_MAC unless PHY is Serdes
>   o [TG3]: More missing PCI IDs
>   o [TG3]: Reset PHY more reliably on 570{3,4,5} chips
>   o [TG3]: Fix 5788/5901, update TSO code
>   o [TG3]: Differentiate between TSO capable and TSO enabled
>   o [TG3]: Add {get,set}_tso ethtool_ops support
>   o [TG3]: Bump version/reldate
>   o [TG3]: Fix tg3_phy_reset_5703_4_5 chip rev test
>   o [TG3]: Bump version/reldate
>   o [TG3]: More fixes and enhancements
> 
> Geert Uytterhoeven:
>   o M68k ptrace
>   o Isapnp warning
>   o fb_cmap and transparency
>   o M68k RTC updates
>   o Rename ariadne2 to zorro8390
>   o M68k mm cleanup
>   o M68k free_io_area()
>   o M68k invalid vs. illegal
>   o Dmasound invalid vs. illegal
>   o M68k cpu_relax()
>   o dmasound SOUND_PCM_READ_RATE
>   o M68k FPU emulator
>   o dmasound core fixes
>   o lmc_proto.c includes <asm/smp.h>
>   o Sonic Ethernet unsafe interrupt
> 
> Greg Kroah-Hartman:
>   o USB: added support for TIOCM_RI and TIOCM_CD to pl2303 driver and
>   fix stupid bug o USB: remove some vendor specific stuff from the
>   pl2303 driver to get other devices to work o [TG3]: pci_device_id
>   can not be marked __devinitdata o [netdrvr sis900] don't call
>   pci_find_device from irq context o USB: fix up a bunch of copyrights
>   that were incorrectly declared o PCI hotplug: fix up a bunch of
>   copyrights that were incorrectly declared o PCI: add PCI_DEVICE()
>   macro to make pci_device_id tables easier to read o PCI: add
>   PCI_DEVICE_CLASS() macro to match PCI_DEVICE() macro
> 
> Henning Meier-Geinitz:
>   o USB: New vendor/product ids for scanner driver
>   o USB: fix check for SCN_MAX_MNR in scanner driver
>   o USB: Fix crash when scanners are disconnected while open
>   o USB: unlink interrupt URBs in scanner driver
> 
> Hirofumi Ogawa:
>   o [netdrvr 8139too] lwake unlock fix
>   o [netdrvr 8139too] remove unused RxConfigMask
>   o [netdrvr 8139too] add more h/w revision ids
> 
> Ian Abbott:
>   o USB: ftdi_sio - additional pids
>   o USB: ftdi_sio - VID/PID for ID TECH IDT1221U USB to RS-232 adapter
>   o USB: ftdi_sio - tidy up write bulk callback
> 
> James Morris:
>   o [TG3]: skb_headlen() cleanup
> 
> Jeff Garzik:
>   o [TG3]: Detect shared (and screaming) interrupts
>   o [TG3]: Convert to using ethtool_ops
>   o [TG3]: Bug fixes for 5705 support
>   o [TG3]: More 5705 updates
>   o [TG3]: More 5705 fixes
>   o [TG3]: Another 5705 fix: enable eeprom write prot as needed
>   o [TG3]: Only write the on-nic sram addr on non-5705
>   o [TG3]: Add 5782 pci id
>   o [netdrvr sis900] ethtool_ops support
>   o [netdrvr sis900] minor bits from 2.6
>   o [netdrvr 8139cp] minor bits from 2.6
>   o [netdrvr 8139cp] ethtool_ops support
>   o [netdrvr 3c59x] add a piece missed in previous ethtool_ops patch
>   o [netdrvr 3c501] ethtool_ops support
>   o [netdrvr] ethtool_ops support in 3c503, 3c505, 3c507
>   o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
>   o [netdrvr pcmcia] ethtool_ops for 3c574, 3c589, aironet4500, axnet
>   o [NET] add SET_ETHTOOL_OPS back-compat hook
>   o [netdrvr pcmcia] use SET_ETHTOOL_OPS in 3c574, 3c589, aironet4500,
>   and axnet o [netdrvr pcmcia] ethtool_ops support for several more
>   pcmcia drivers o [netdrvr 8139too] minor bits from 2.6
>   o [wireless airo] build fixes
>   o [scsi] add SCSI opcodes and SAM status codes to scsi/scsi.h
> 
> Judd Montgomery:
>   o USB: visor.h[c] USB device IDs documentation
> 
> Marc-Christian Petersen:
>   o DRM menu the right fix
> 
> Matthew Wilcox:
>   o [netdrvr 3c59x] ethtool_ops support
> 
> Nemosoft Unv.:
>   o USB: PWC 8.11
> 
> Paul Mackerras:
>   o PPC32: Add support for DMA mapping on non-cache-coherent machines
>   o PPC32: Add the infrastructure to allow for 64-bit PTEs
>   o PPC32: Fix typo in arch/ppc/Makefile
>   o PPC32: Use CONFIG_IBM_OPENBIOS instead of CONFIG_TREEBOOT
>   o PPC32: Add support for the PPC970 processor
>   o PPC32: Minor cleanups and fixes for 4xx/BookE systems
>   o PPC32: Restructure signal code, new ucontext structure, add
>   swapcontext syscall o PPC32: Implement semtimedop system call
> 
> Paul Mundt:
>   o Add Paul Mundt to CREDITS
> 
> Randy Dunlap:
>   o add seq_file "single" interfaces
> 
> Stefan Becker:
>   o USB: acm.c update for new devices
> 
> Stefan Rompf:
>   o [netdrvr 8139too] use mii_check_media lib function, instead of
>   homebrew MII bitbanging.
> 
> Steven Cole:
>   o Add 39 Configure.help texts from -ac tree
>   o Add six more Configure.help texts from the -ac tree
> 
> Tom Rini:
>   o PPC32: Change the default behavior of a kernel with KGDB
>   o PPC32: Fix KGDB and userland GDB interactions
> 
> Willy Tarreau:
>   o Fix log buffer length issues
> 
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
A computer without Microsoft is like chocolate cake without mustard.


^ permalink raw reply	[flat|nested] 28+ messages in thread

* RE: Linux 2.4.23-pre2
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
  2003-08-30 16:22 ` Dave Bentham
@ 2003-08-30 19:35 ` system_lists
  2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 28+ messages in thread
From: system_lists @ 2003-08-30 19:35 UTC (permalink / raw)
  To: 'Marcelo Tosatti', 'lkml'

Hello Marcelo,

   You have forgot the "Patrick McHardy [kaber@trash.net]" patch to get the
MASQUERADE/FORWARD working again ( so important! :-) ).

Please, add it when you get a minute.

Thanks.

===== net/ipv4/netfilter/ipt_MASQUERADE.c 1.6 vs edited ===== 
--- 1.6/net/ipv4/netfilter/ipt_MASQUERADE.c     Tue Aug 12 11:30:12 2003 
+++ edited/net/ipv4/netfilter/ipt_MASQUERADE.c  Thu Aug 28 16:54:15 2003 
@@ -90,6 +90,7 @@ 
 #ifdef CONFIG_IP_ROUTE_FWMARK 
        key.fwmark = (*pskb)->nfmark; 
 #endif 
+       key.oif = 0; 
        if (ip_route_output_key(&rt, &key) != 0) { 
                 /* Funky routing can do this. */ 
                 if (net_ratelimit())


> -----Mensaje original-----
> De: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] En nombre de Marcelo Tosatti
> Enviado el: sábado, 30 de agosto de 2003 17:48
> Para: lkml
> Asunto: Linux 2.4.23-pre2
> 
> 
> Hello,
> 
> Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> changes from Alan, network drivers update from Jeff, amongst other fixes
> and updates.
> 
> 
> 
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
> 
> <cw:sgi.com>:
>   o Add SGI IOC4 IDE Driver
>   o SGI SN Serial/Console Driver
> 
> <davej:redhat.com>:
>   o USB: Add Minolta Dimage F300 to unusual_devs
> 
> <gaa:ulticom.com>:
>   o USB: new ids for io_ti driver
> 
> <javier:tudela.mad.ttd.net>:
>   o [wireless airo] add support for MIC and latest firmwares
> 
> <kevino:asti-usa.com>:
>   o USB: bug in EHCI device reset through transaction
> 
> <malte.d:gmx.net>:
>   o USB: support for Zaurus 750/760 to usbnet.c (2.4.22-pre8) + code
> cleanup backport from 2.6
> 
> <marcelo:logos.cnet>:
>   o Changed hch contact information
>   o Fix compilation warning in panic.c
>   o Delete unused drivers/scsi/aic79xx (now aic7xxx supports it)
>   o add sysctl bits for setuid core
>   o Changed EXTRAVERSION to -pre2
> 
> <masanari.iida:hp.com>:
>   o SCSI blacklist HP Va7140
> 
> <mike.miller:hp.com>:
>   o cciss multi-path failover in md
> 
> <mporter:kernel.crashing.org>:
>   o PPC32: Add support for the IBM PPC 440 family of processors
>   o PPC32: Add support for DMA controllers on PPC 4xx processors
> 
> <russell_d_cagle:mindspring.com>:
>   o USB: add Garmin iQue support to visor driver
> 
> <thomas:winischhofer.net>:
>   o sisfb update
> 
> <vmlinuz386:yahoo.com.ar>:
>   o PCI Hotplug: fix __FUNCTION__ warnings
> 
> Alan Cox:
>   o remove all the 440gx broken bios stuff
>   o replace the pci router logic with working code
>   o update INDEX for docs
>   o wolfson touchscreen docs
>   o amd watchdog update
>   o update i8xx watchdog
>   o improved extra key bounce fix
>   o fix a missing rocket card
>   o warning fix
>   o fix nowayout handling on softdog
>   o fix missing formatting info in ide-cd
>   o add open/close methods to ide-default for hotplug
>   o move sibyte driver into the right dir
>   o Add Intel ICH3 hotplug support
>   o siimage: set a sata flag on the hwif so we can do cable det
>   o update ide raid for info pointer changes
>   o update ide headers for hotplug
>   o fix cable detect issue with sata
>   o split ide probe code up
>   o Add disk hotplug to the IDE core
>   o update cpia driver to fix warnings
>   o aacraid update
>   o wolfson ac97 touchscreen driver
>   o ad1889 error handling fixes
>   o ALi5455 update
>   o cmpci update
>   o fix i810 audio leak
>   o makefile/config update for sound changes
>   o USB audio fixes for OSS API compliance
>   o VGA also works on IA64
>   o tdfxfb updates for 24/32 and big endian
>   o allow setuid core dumps
>   o add sysctl number for setuid core
>   o Add headers for wolfson codecs
>   o Fix the file sharing/initrd bug
>   o resend - mm checks have precedence bugs
> 
> Alan Stern:
>   o USB: More unusual_devs.h entry updates
>   o USB: More unusual_devs.h stuff
>   o USB: Another unusual_devs.h entry update
> 
> Andrea Arcangeli:
>   o vmalloc allocations in ipc needs smp initialized
> 
> Andrew Morton:
>   o fix possible busywait in rtc_read()
>   o tty oops fix
> 
> Dan Streetman:
>   o USB: backport usbfs 'disconnect'
> 
> David Brownell:
>   o USB: ehci needs a readb() on IDP425 PCI (ARM)
>   o USB: ehci-hcd and period=1frame hs interrupts
> 
> David S. Miller:
>   o [TG3]: Update to irqreturn_t
>   o [TG3]: Sync TSO changes from base 2.5.x
>   o [TG3]: Merge comment typo fixes from 2.5.x
>   o [TG3]: Initial implementation of 5705 support
>   o [TG3]: Fix statistics on 5705
>   o [TG3]: Do not reset the RX_MAC unless PHY is Serdes
>   o [TG3]: More missing PCI IDs
>   o [TG3]: Reset PHY more reliably on 570{3,4,5} chips
>   o [TG3]: Fix 5788/5901, update TSO code
>   o [TG3]: Differentiate between TSO capable and TSO enabled
>   o [TG3]: Add {get,set}_tso ethtool_ops support
>   o [TG3]: Bump version/reldate
>   o [TG3]: Fix tg3_phy_reset_5703_4_5 chip rev test
>   o [TG3]: Bump version/reldate
>   o [TG3]: More fixes and enhancements
> 
> Geert Uytterhoeven:
>   o M68k ptrace
>   o Isapnp warning
>   o fb_cmap and transparency
>   o M68k RTC updates
>   o Rename ariadne2 to zorro8390
>   o M68k mm cleanup
>   o M68k free_io_area()
>   o M68k invalid vs. illegal
>   o Dmasound invalid vs. illegal
>   o M68k cpu_relax()
>   o dmasound SOUND_PCM_READ_RATE
>   o M68k FPU emulator
>   o dmasound core fixes
>   o lmc_proto.c includes <asm/smp.h>
>   o Sonic Ethernet unsafe interrupt
> 
> Greg Kroah-Hartman:
>   o USB: added support for TIOCM_RI and TIOCM_CD to pl2303 driver and fix
> stupid bug
>   o USB: remove some vendor specific stuff from the pl2303 driver to get
> other devices to work
>   o [TG3]: pci_device_id can not be marked __devinitdata
>   o [netdrvr sis900] don't call pci_find_device from irq context
>   o USB: fix up a bunch of copyrights that were incorrectly declared
>   o PCI hotplug: fix up a bunch of copyrights that were incorrectly
> declared
>   o PCI: add PCI_DEVICE() macro to make pci_device_id tables easier to
> read
>   o PCI: add PCI_DEVICE_CLASS() macro to match PCI_DEVICE() macro
> 
> Henning Meier-Geinitz:
>   o USB: New vendor/product ids for scanner driver
>   o USB: fix check for SCN_MAX_MNR in scanner driver
>   o USB: Fix crash when scanners are disconnected while open
>   o USB: unlink interrupt URBs in scanner driver
> 
> Hirofumi Ogawa:
>   o [netdrvr 8139too] lwake unlock fix
>   o [netdrvr 8139too] remove unused RxConfigMask
>   o [netdrvr 8139too] add more h/w revision ids
> 
> Ian Abbott:
>   o USB: ftdi_sio - additional pids
>   o USB: ftdi_sio - VID/PID for ID TECH IDT1221U USB to RS-232 adapter
>   o USB: ftdi_sio - tidy up write bulk callback
> 
> James Morris:
>   o [TG3]: skb_headlen() cleanup
> 
> Jeff Garzik:
>   o [TG3]: Detect shared (and screaming) interrupts
>   o [TG3]: Convert to using ethtool_ops
>   o [TG3]: Bug fixes for 5705 support
>   o [TG3]: More 5705 updates
>   o [TG3]: More 5705 fixes
>   o [TG3]: Another 5705 fix: enable eeprom write prot as needed
>   o [TG3]: Only write the on-nic sram addr on non-5705
>   o [TG3]: Add 5782 pci id
>   o [netdrvr sis900] ethtool_ops support
>   o [netdrvr sis900] minor bits from 2.6
>   o [netdrvr 8139cp] minor bits from 2.6
>   o [netdrvr 8139cp] ethtool_ops support
>   o [netdrvr 3c59x] add a piece missed in previous ethtool_ops patch
>   o [netdrvr 3c501] ethtool_ops support
>   o [netdrvr] ethtool_ops support in 3c503, 3c505, 3c507
>   o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
>   o [netdrvr pcmcia] ethtool_ops for 3c574, 3c589, aironet4500, axnet
>   o [NET] add SET_ETHTOOL_OPS back-compat hook
>   o [netdrvr pcmcia] use SET_ETHTOOL_OPS in 3c574, 3c589, aironet4500, and
> axnet
>   o [netdrvr pcmcia] ethtool_ops support for several more pcmcia drivers
>   o [netdrvr 8139too] minor bits from 2.6
>   o [wireless airo] build fixes
>   o [scsi] add SCSI opcodes and SAM status codes to scsi/scsi.h
> 
> Judd Montgomery:
>   o USB: visor.h[c] USB device IDs documentation
> 
> Marc-Christian Petersen:
>   o DRM menu the right fix
> 
> Matthew Wilcox:
>   o [netdrvr 3c59x] ethtool_ops support
> 
> Nemosoft Unv.:
>   o USB: PWC 8.11
> 
> Paul Mackerras:
>   o PPC32: Add support for DMA mapping on non-cache-coherent machines
>   o PPC32: Add the infrastructure to allow for 64-bit PTEs
>   o PPC32: Fix typo in arch/ppc/Makefile
>   o PPC32: Use CONFIG_IBM_OPENBIOS instead of CONFIG_TREEBOOT
>   o PPC32: Add support for the PPC970 processor
>   o PPC32: Minor cleanups and fixes for 4xx/BookE systems
>   o PPC32: Restructure signal code, new ucontext structure, add
> swapcontext syscall
>   o PPC32: Implement semtimedop system call
> 
> Paul Mundt:
>   o Add Paul Mundt to CREDITS
> 
> Randy Dunlap:
>   o add seq_file "single" interfaces
> 
> Stefan Becker:
>   o USB: acm.c update for new devices
> 
> Stefan Rompf:
>   o [netdrvr 8139too] use mii_check_media lib function, instead of
> homebrew MII bitbanging.
> 
> Steven Cole:
>   o Add 39 Configure.help texts from -ac tree
>   o Add six more Configure.help texts from the -ac tree
> 
> Tom Rini:
>   o PPC32: Change the default behavior of a kernel with KGDB
>   o PPC32: Fix KGDB and userland GDB interactions
> 
> Willy Tarreau:
>   o Fix log buffer length issues
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


^ permalink raw reply	[flat|nested] 28+ messages in thread

* [PATCH] check_gcc for i386
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
  2003-08-30 16:22 ` Dave Bentham
  2003-08-30 19:35 ` system_lists
@ 2003-08-30 22:05 ` J.A. Magallon
  2003-08-30 22:58   ` Marcelo Tosatti
  2003-08-30 23:01   ` Andre Tomt
  2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
                   ` (4 subsequent siblings)
  7 siblings, 2 replies; 28+ messages in thread
From: J.A. Magallon @ 2003-08-30 22:05 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: lkml


On 08.30, Marcelo Tosatti wrote:
> 
> Hello,
> 
> Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> changes from Alan, network drivers update from Jeff, amongst other fixes
> and updates.
> 

New try...
Plz, could you include this on your queue ?

--- linux-2.4.21-bp1/arch/i386/Makefile.orig	2003-06-18 23:40:25.000000000 +0200
+++ linux-2.4.21-bp1/arch/i386/Makefile	2003-06-18 23:59:25.000000000 +0200
@@ -53,11 +53,11 @@
 endif
 
 ifdef CONFIG_MPENTIUMIII
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
 endif
 
 ifdef CONFIG_MPENTIUM4
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
 endif
 
 ifdef CONFIG_MK6

-- 
J.A. Magallon <jamagallon@able.es>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-jam1m (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-1mdk))

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
@ 2003-08-30 22:58   ` Marcelo Tosatti
  2003-08-30 23:20     ` Norberto BENSA
                       ` (2 more replies)
  2003-08-30 23:01   ` Andre Tomt
  1 sibling, 3 replies; 28+ messages in thread
From: Marcelo Tosatti @ 2003-08-30 22:58 UTC (permalink / raw)
  To: J.A. Magallon; +Cc: Marcelo Tosatti, lkml



On Sun, 31 Aug 2003, J.A. Magallon wrote:

> 
> On 08.30, Marcelo Tosatti wrote:
> > 
> > Hello,
> > 
> > Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> > changes from Alan, network drivers update from Jeff, amongst other fixes
> > and updates.
> > 
> 
> New try...
> Plz, could you include this on your queue ?
> 
> --- linux-2.4.21-bp1/arch/i386/Makefile.orig	2003-06-18 23:40:25.000000000 +0200
> +++ linux-2.4.21-bp1/arch/i386/Makefile	2003-06-18 23:59:25.000000000 +0200
> @@ -53,11 +53,11 @@
>  endif
>  
>  ifdef CONFIG_MPENTIUMIII
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
>  endif
>  
>  ifdef CONFIG_MPENTIUM4
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
>  endif
>  
>  ifdef CONFIG_MK6

OK, I forgot what that does. Can you please explain in detail what 
check_gcc does. 


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
  2003-08-30 22:58   ` Marcelo Tosatti
@ 2003-08-30 23:01   ` Andre Tomt
  1 sibling, 0 replies; 28+ messages in thread
From: Andre Tomt @ 2003-08-30 23:01 UTC (permalink / raw)
  To: J.A. Magallon; +Cc: Marcelo Tosatti, lkml

J.A. Magallon wrote:

> On 08.30, Marcelo Tosatti wrote:
> 
>>Hello,
>>
>>Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
>>changes from Alan, network drivers update from Jeff, amongst other fixes
>>and updates.
>>
> 
> 
> New try...
> Plz, could you include this on your queue ?

This can be a potentially harmful change, suddenly exposing compiler 
bugs and other compiler related problems in the kernel code we have not 
yet seen. On one side, these bugs _should_ get fixed, on the other side, 
we might not find them all before release. Also, the pentium3 and 
pentium4 options have been known to compile for example bad SSE code in 
some gcc versions, something that's giving me a feeling those gcc 
options may be a little immature to use for a stable kernel series.

In my opinion, of course.

-- 
Cheers,
André Tomt
andre@tomt.net


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: Linux 2.4.23-pre2 - airo.c compile failure
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
                   ` (2 preceding siblings ...)
  2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
@ 2003-08-30 23:11 ` Eyal Lebedinsky
  2003-09-03 15:56   ` [patch] fix airo.c compile failure with gcc 2.95 Adrian Bunk
  2003-08-31  9:21 ` [PATCH] correct AT_PLATFORM for HT cpus J.A. Magallon
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 28+ messages in thread
From: Eyal Lebedinsky @ 2003-08-30 23:11 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: lkml

Marcelo Tosatti wrote:
> 
> Hello,
> 
> Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE

gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
-Wstrict-pro
totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer
 -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
-DMODULE -DM
ODVERSIONS -include
/data2/usr/local/src/linux-2.4-pre/include/linux/modversions
.h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=airo 
-DEXPORT_SYMTAB -c ai
ro.c
airo.c: In function `airo_get_power':
airo.c:5659: parse error before `int'
airo.c:5660: `mode' undeclared (first use in this function)
airo.c:5660: (Each undeclared identifier is reported only once
airo.c:5660: for each function it appears in.)
airo.c: In function `writerids':
airo.c:6673: warning: unused variable `enabled'
make[3]: *** [airo.o] Error 1
make[3]: Leaving directory
`/data2/usr/local/src/linux-2.4-pre/drivers/net/wirel
ess'

Cannot tell if it is a bad merge ('int mode =' line should be earlier?)
or bad programming (declaration must come first).

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 22:58   ` Marcelo Tosatti
@ 2003-08-30 23:20     ` Norberto BENSA
  2003-08-31  2:39       ` Marcelo Tosatti
  2003-08-30 23:31     ` J.A. Magallon
  2003-08-30 23:37     ` Alan Cox
  2 siblings, 1 reply; 28+ messages in thread
From: Norberto BENSA @ 2003-08-30 23:20 UTC (permalink / raw)
  To: Marcelo Tosatti, J.A. Magallon; +Cc: linux-kernel

[-- Attachment #1: signed data --]
[-- Type: text/plain, Size: 404 bytes --]

Marcelo Tosatti wrote:
> On Sun, 31 Aug 2003, J.A. Magallon wrote:
> > +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> >  endif
> >
>
> OK, I forgot what that does. Can you please explain in detail what
> check_gcc does.

Hmmm... Parhaps it checks if gcc supports those command line parameters (just 
a wild guess)? Marcelo, do you need a break? :-)

With best regards,
Norberto

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 22:58   ` Marcelo Tosatti
  2003-08-30 23:20     ` Norberto BENSA
@ 2003-08-30 23:31     ` J.A. Magallon
  2003-08-30 23:37     ` Alan Cox
  2 siblings, 0 replies; 28+ messages in thread
From: J.A. Magallon @ 2003-08-30 23:31 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: lkml


On 08.31, Marcelo Tosatti wrote:
> 
> 
> On Sun, 31 Aug 2003, J.A. Magallon wrote:
> 
> > 
> > On 08.30, Marcelo Tosatti wrote:
> > > 
> > > Hello,
> > > 
> > > Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> > > changes from Alan, network drivers update from Jeff, amongst other fixes
> > > and updates.
> > > 
> > 
> > New try...
> > Plz, could you include this on your queue ?
> > 
> > --- linux-2.4.21-bp1/arch/i386/Makefile.orig	2003-06-18 23:40:25.000000000 +0200
> > +++ linux-2.4.21-bp1/arch/i386/Makefile	2003-06-18 23:59:25.000000000 +0200
> > @@ -53,11 +53,11 @@
> >  endif
> >  
> >  ifdef CONFIG_MPENTIUMIII
> > -CFLAGS += -march=i686
> > +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
> >  endif
> >  
> >  ifdef CONFIG_MPENTIUM4
> > -CFLAGS += -march=i686
> > +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> >  endif
> >  
> >  ifdef CONFIG_MK6
> 
> OK, I forgot what that does. Can you please explain in detail what 
> check_gcc does. 
> 
> 

arch/i386/Makefile:

check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi)

So

$(call check_gcc,-march=pentium3,-march=i686)

checks if gcc supports -march=pentium3 and returns it, if not it returns the
fallbask (-march=i686). So it changes i686 to pentium3 if supported by the
compiler. Same for P4. It will help in instruction scheduling and so on.

I will also answer here to Andre...

> 
> This can be a potentially harmful change, suddenly exposing compiler 
> bugs and other compiler related problems in the kernel code we have not 
> yet seen. On one side, these bugs _should_ get fixed, on the other side, 
> we might not find them all before release. Also, the pentium3 and 
> pentium4 options have been known to compile for example bad SSE code in 
> some gcc versions, something that's giving me a feeling those gcc 
> options may be a little immature to use for a stable kernel series.
> 

Testing till now:
- Myself ;), on PIII and P4, and also on PII (with additional patch I
  would like to submit if this goes in...), all the gccs in mandrake
  since 2.96, I think, to 3.3.1
- Some people apart from me is using it and I have not received any
  complaint about this.
- My -jam patchset has survived benchmarks of rwhron@earthlink.net,
  see http://home.earthlink.net/~rwhron/kernel/bigbox.html.
. It is in 2.6 and nobody has showed any problem.
- We are still in early -pre, so its time to chase bugs...;)

Any question/comment ?

-- 
J.A. Magallon <jamagallon@able.es>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-jam1m (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-1mdk))

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 22:58   ` Marcelo Tosatti
  2003-08-30 23:20     ` Norberto BENSA
  2003-08-30 23:31     ` J.A. Magallon
@ 2003-08-30 23:37     ` Alan Cox
  2003-08-31  0:47       ` Jeff Garzik
  2 siblings, 1 reply; 28+ messages in thread
From: Alan Cox @ 2003-08-30 23:37 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: J.A. Magallon, Marcelo Tosatti, lkml

On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
> >  ifdef CONFIG_MPENTIUM4
> > -CFLAGS += -march=i686
> > +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> >  endif
> >  
> >  ifdef CONFIG_MK6
> 
> OK, I forgot what that does. Can you please explain in detail what 
> check_gcc does. 

Tries to use gcc with the options given and if not falls back to the
second set suggested. So it'll try -march=pentium4 (new gcc) and 
fall back to -march=i686


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 23:37     ` Alan Cox
@ 2003-08-31  0:47       ` Jeff Garzik
  2003-08-31  0:59         ` Kurt Wall
  2003-08-31  3:03         ` Marcelo Tosatti
  0 siblings, 2 replies; 28+ messages in thread
From: Jeff Garzik @ 2003-08-31  0:47 UTC (permalink / raw)
  To: Alan Cox; +Cc: Marcelo Tosatti, J.A. Magallon, Marcelo Tosatti, lkml

Alan Cox wrote:
> On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
> 
>>> ifdef CONFIG_MPENTIUM4
>>>-CFLAGS += -march=i686
>>>+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
>>> endif
>>> 
>>> ifdef CONFIG_MK6
>>
>>OK, I forgot what that does. Can you please explain in detail what 
>>check_gcc does. 
> 
> 
> Tries to use gcc with the options given and if not falls back to the
> second set suggested. So it'll try -march=pentium4 (new gcc) and 
> fall back to -march=i686


Yep.  I introduced check_gcc into 2.4 (backported from 2.5), in fact.

The above change does exactly what Alan describes, and is a patch I was 
planning to submit myself :)  I did not want to change compiler options 
at the time when I submitted the check_gcc patch, but after many months 
of manually patching to get the best compiler flags, it seems solid.

	Jeff




^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-31  0:47       ` Jeff Garzik
@ 2003-08-31  0:59         ` Kurt Wall
  2003-08-31  3:03         ` Marcelo Tosatti
  1 sibling, 0 replies; 28+ messages in thread
From: Kurt Wall @ 2003-08-31  0:59 UTC (permalink / raw)
  To: lkml

Quoth Jeff Garzik:
>
> Yep.  I introduced check_gcc into 2.4 (backported from 2.5), in fact.
> 
> The above change does exactly what Alan describes, and is a patch I was 
> planning to submit myself :)  I did not want to change compiler options 
> at the time when I submitted the check_gcc patch, but after many months 
> of manually patching to get the best compiler flags, it seems solid.

[nod]

Works fine here with a Pentium II, Pentium III, and an Athlon.

Kurt
-- 
Boy, n.:
	A noise with dirt on it.

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-30 23:20     ` Norberto BENSA
@ 2003-08-31  2:39       ` Marcelo Tosatti
  0 siblings, 0 replies; 28+ messages in thread
From: Marcelo Tosatti @ 2003-08-31  2:39 UTC (permalink / raw)
  To: Norberto BENSA; +Cc: J.A. Magallon, linux-kernel



On Sat, 30 Aug 2003, Norberto BENSA wrote:

> Marcelo Tosatti wrote:
> > On Sun, 31 Aug 2003, J.A. Magallon wrote:
> > > +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> > >  endif
> > >
> >
> > OK, I forgot what that does. Can you please explain in detail what
> > check_gcc does.
> 
> Hmmm... Parhaps it checks if gcc supports those command line parameters (just 
> a wild guess)? Marcelo, do you need a break? :-)

Actually, I do need a break, thanks. But my worries were about the new
flags doing nasty things.

See?

Well, I indeed need to sleep: Good night. 


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-31  0:47       ` Jeff Garzik
  2003-08-31  0:59         ` Kurt Wall
@ 2003-08-31  3:03         ` Marcelo Tosatti
  2003-09-01 19:14           ` Marcelo Tosatti
  1 sibling, 1 reply; 28+ messages in thread
From: Marcelo Tosatti @ 2003-08-31  3:03 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Alan Cox, J.A. Magallon, Marcelo Tosatti, lkml



On Sat, 30 Aug 2003, Jeff Garzik wrote:

> Alan Cox wrote:
> > On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
> > 
> >>> ifdef CONFIG_MPENTIUM4
> >>>-CFLAGS += -march=i686
> >>>+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> >>> endif
> >>> 
> >>> ifdef CONFIG_MK6
> >>
> >>OK, I forgot what that does. Can you please explain in detail what 
> >>check_gcc does. 
> > 
> > 
> > Tries to use gcc with the options given and if not falls back to the
> > second set suggested. So it'll try -march=pentium4 (new gcc) and 
> > fall back to -march=i686
> 
> 
> Yep.  I introduced check_gcc into 2.4 (backported from 2.5), in fact.
> 
> The above change does exactly what Alan describes, and is a patch I was 
> planning to submit myself :)  I did not want to change compiler options 
> at the time when I submitted the check_gcc patch, but after many months 
> of manually patching to get the best compiler flags, it seems solid.

I'm just worried about having nicey gcc surprises. Alan thinks its ok, and 
you too so I guess I'll just apply it tomorrow and see what happens




^ permalink raw reply	[flat|nested] 28+ messages in thread

* [PATCH] correct AT_PLATFORM for HT cpus
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
                   ` (3 preceding siblings ...)
  2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
@ 2003-08-31  9:21 ` J.A. Magallon
  2003-09-02 15:18 ` [patch] 2.4.23-pre2: fix rocket.c compilation Adrian Bunk
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 28+ messages in thread
From: J.A. Magallon @ 2003-08-31  9:21 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: lkml


On 08.30, Marcelo Tosatti wrote:
> 
> Hello,
> 
> Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> changes from Alan, network drivers update from Jeff, amongst other fixes
> and updates.
> 

In shortest: Pentium4 with HT do not realize they are themselves an i686.
Even, they do not know what they are. This makes P4HT select i386 libraries
at runtime, instead of i686 ones.

In short: binfmt_elf::create_elf_tables() copies the AT_PLATFORM in the
place pointed by u_platform, and then copies the pointer to elf tables.
But, in the HT case, u_platform gets changed in the middle, beacuse it
is also used as the beginning of the stack, that is shifted for HT
processors to avoid cache collisions. So then
it puts a pointer to garbage in the elf tables:

    if (k_platform) {
        platform_len = strlen(k_platform) + 1;
        u_platform = p - platform_len;
        __copy_to_user(u_platform, k_platform, platform_len);
    } else
        u_platform = p;
...
    if(smp_num_siblings > 1)
        u_platform = u_platform - ((current->pid % 64) << 7);
...
    if (k_platform) {
        sp -= 2;
        NEW_AUX_ENT(0, AT_PLATFORM, (elf_addr_t)(unsigned long) u_platform);
    }

Solution is to use separate variables to store u_platform and the stack_top:

--- linux/fs/binfmt_elf.c.orig	2002-12-28 00:12:32.000000000 +0100
+++ linux/fs/binfmt_elf.c	2002-12-28 00:32:37.000000000 +0100
@@ -116,11 +116,14 @@
 	elf_caddr_t *argv;
 	elf_caddr_t *envp;
 	elf_addr_t *sp, *csp;
+	char *stack_top;
 	char *k_platform, *u_platform;
 	long hwcap;
 	size_t platform_len = 0;
 	size_t len;
 
+	stack_top = p;
+
 	/*
 	 * Get hold of platform and hardware capabilities masks for
 	 * the machine we are running on.  In some cases (Sparc), 
@@ -135,8 +138,8 @@
 		platform_len = strlen(k_platform) + 1;
 		u_platform = p - platform_len;
 		__copy_to_user(u_platform, k_platform, platform_len);
-	} else
-		u_platform = p;
+		stack_top = u_platform;
+	}
 
 #if defined(__i386__) && defined(CONFIG_SMP)
 	/*
@@ -149,15 +152,14 @@
 	 * processors. This keeps Mr Marcelo Person happier but should be
 	 * removed for 2.5
 	 */
-	 
 	if(smp_num_siblings > 1)
-		u_platform = u_platform - ((current->pid % 64) << 7);
+		stack_top -= ((current->pid % 64) << 7);
 #endif	
 
 	/*
 	 * Force 16 byte _final_ alignment here for generality.
 	 */
-	sp = (elf_addr_t *)(~15UL & (unsigned long)(u_platform));
+	sp = (elf_addr_t *)(~15UL & (unsigned long)(stack_top));
 	csp = sp;
 	csp -= (1+DLINFO_ITEMS)*2 + (k_platform ? 2 : 0);
 #ifdef DLINFO_ARCH_ITEMS

As other patches, tested by myself. And Mandrake kernel includes it.
Comments ?

-- 
J.A. Magallon <jamagallon@able.es>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-jam1m (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-1mdk))

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH] check_gcc for i386
  2003-08-31  3:03         ` Marcelo Tosatti
@ 2003-09-01 19:14           ` Marcelo Tosatti
  0 siblings, 0 replies; 28+ messages in thread
From: Marcelo Tosatti @ 2003-09-01 19:14 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Alan Cox, J.A. Magallon, lkml



On Sun, 31 Aug 2003, Marcelo Tosatti wrote:

> 
> 
> On Sat, 30 Aug 2003, Jeff Garzik wrote:
> 
> > Alan Cox wrote:
> > > On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
> > > 
> > >>> ifdef CONFIG_MPENTIUM4
> > >>>-CFLAGS += -march=i686
> > >>>+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> > >>> endif
> > >>> 
> > >>> ifdef CONFIG_MK6
> > >>
> > >>OK, I forgot what that does. Can you please explain in detail what 
> > >>check_gcc does. 
> > > 
> > > 
> > > Tries to use gcc with the options given and if not falls back to the
> > > second set suggested. So it'll try -march=pentium4 (new gcc) and 
> > > fall back to -march=i686
> > 
> > 
> > Yep.  I introduced check_gcc into 2.4 (backported from 2.5), in fact.
> > 
> > The above change does exactly what Alan describes, and is a patch I was 
> > planning to submit myself :)  I did not want to change compiler options 
> > at the time when I submitted the check_gcc patch, but after many months 
> > of manually patching to get the best compiler flags, it seems solid.
> 
> I'm just worried about having nicey gcc surprises. Alan thinks its ok, and 
> you too so I guess I'll just apply it tomorrow and see what happens

Changed my mind: I already have enough thinks to care about in 2.4.23 and 
I prefer NOT accepting such changes instead of doing them. I might change 
my mind once 2.4.23 is out. 


^ permalink raw reply	[flat|nested] 28+ messages in thread

* [patch] 2.4.23-pre2: fix rocket.c compilation
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
                   ` (4 preceding siblings ...)
  2003-08-31  9:21 ` [PATCH] correct AT_PLATFORM for HT cpus J.A. Magallon
@ 2003-09-02 15:18 ` Adrian Bunk
  2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
  2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
  7 siblings, 0 replies; 28+ messages in thread
From: Adrian Bunk @ 2003-09-02 15:18 UTC (permalink / raw)
  To: Marcelo Tosatti, Alan Cox; +Cc: lkml

On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Alan Cox:
>...
>   o fix a missing rocket card
>...

This patch accidentially also includes one line of the "Make tty->count
atomic" patch resulting in the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -W
all -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=rocket  -c -o rocket.o rocket.c
rocket.c: In function `rp_close':
rocket.c:1055: error: request for member `counter' in something not a 
structure or union
make[3]: *** [rocket.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/char'

<--  snip  -->


The following patch reverts this part of the patch:

--- linux-2.4.23-pre2-full/drivers/char/rocket.c.old	2003-09-02 17:14:43.000000000 +0200
+++ linux-2.4.23-pre2-full/drivers/char/rocket.c	2003-09-02 17:15:07.000000000 +0200
@@ -1052,7 +1052,7 @@
 		restore_flags(flags);
 		return;
 	}
-	if ((atomic_read(&tty->count) == 1) && (info->count != 1)) {
+	if ((tty->count == 1) && (info->count != 1)) {
 		/*
 		 * Uh, oh.  tty->count is 1, which means that the tty
 		 * structure will be freed.  Info->count should always



Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Alan Cox:
>...
>   o fix a missing rocket card
>...

This patch accidentially also includes one line of the "Make tty->count
atomic" patch resulting in the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -W
all -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=rocket  -c -o rocket.o rocket.c
rocket.c: In function `rp_close':
rocket.c:1055: error: request for member `counter' in something not a 
structure or union
make[3]: *** [rocket.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/char'

<--  snip  -->


The following patch reverts this part of the patch:

--- linux-2.4.23-pre2-full/drivers/char/rocket.c.old	2003-09-02 17:14:43.000000000 +0200
+++ linux-2.4.23-pre2-full/drivers/char/rocket.c	2003-09-02 17:15:07.000000000 +0200
@@ -1052,7 +1052,7 @@
 		restore_flags(flags);
 		return;
 	}
-	if ((atomic_read(&tty->count) == 1) && (info->count != 1)) {
+	if ((tty->count == 1) && (info->count != 1)) {
 		/*
 		 * Uh, oh.  tty->count is 1, which means that the tty
 		 * structure will be freed.  Info->count should always



Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 28+ messages in thread

* 2.4.23-pre2: 3c515.c doesn't compile non-modular
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
                   ` (5 preceding siblings ...)
  2003-09-02 15:18 ` [patch] 2.4.23-pre2: fix rocket.c compilation Adrian Bunk
@ 2003-09-02 16:49 ` Adrian Bunk
  2003-09-02 17:47   ` [PATCH] " Jeff Garzik
  2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
  7 siblings, 1 reply; 28+ messages in thread
From: Adrian Bunk @ 2003-09-02 16:49 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: lkml

On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Jeff Garzik:
>...
>   o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
>...

This change broke non-modular compile of 3c515.c ("debug" is declared 
inside an #ifdef MODULE):

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=3c515  -c -o 3c515.o 3c515.c
3c515.c: In function `netdev_get_msglevel':
3c515.c:1621: error: `debug' undeclared (first use in this function)
3c515.c:1621: error: (Each undeclared identifier is reported only once
3c515.c:1621: error: for each function it appears in.)
3c515.c: In function `netdev_set_msglevel':
3c515.c:1626: error: `debug' undeclared (first use in this function)
make[3]: *** [3c515.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/net'

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Jeff Garzik:
>...
>   o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
>...

This change broke non-modular compile of 3c515.c ("debug" is declared 
inside an #ifdef MODULE):

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=3c515  -c -o 3c515.o 3c515.c
3c515.c: In function `netdev_get_msglevel':
3c515.c:1621: error: `debug' undeclared (first use in this function)
3c515.c:1621: error: (Each undeclared identifier is reported only once
3c515.c:1621: error: for each function it appears in.)
3c515.c: In function `netdev_set_msglevel':
3c515.c:1626: error: `debug' undeclared (first use in this function)
make[3]: *** [3c515.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/net'

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 28+ messages in thread

* [PATCH] Re: 2.4.23-pre2: 3c515.c doesn't compile non-modular
  2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
@ 2003-09-02 17:47   ` Jeff Garzik
  0 siblings, 0 replies; 28+ messages in thread
From: Jeff Garzik @ 2003-09-02 17:47 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: lkml, Linus Torvalds

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

Adrian Bunk wrote:
> On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
> 
>>...
>>Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
>>============================================
>>...
>>Jeff Garzik:
>>...
>>  o [netdrvr] ethtool_ops support for 3c515, 3c523, 3c527, and dmfe
>>...
> 
> 
> This change broke non-modular compile of 3c515.c ("debug" is declared 
> inside an #ifdef MODULE):

I'm pretty impressed that it broke, actually.  "debug" is a weird 
pseudo-variable that's really another global variable underneath, 
corkscrew_debug...  but MODULE_PARM() uses "debug".  Sigh.

Further encouragement for me to convert net drivers over to Rusty's new 
module parameter stuff, I suppose.  His stuff is at least type-checked, 
and would have caught this problem -- a big advantage over the 2.4.x 
MODULE_PARM() stuff.

> ...
> gcc -D__KERNEL__ 
> -I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -Wall 
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
> -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
> include -DKBUILD_BASENAME=3c515  -c -o 3c515.o 3c515.c
> 3c515.c: In function `netdev_get_msglevel':
> 3c515.c:1621: error: `debug' undeclared (first use in this function)
> 3c515.c:1621: error: (Each undeclared identifier is reported only once
> 3c515.c:1621: error: for each function it appears in.)
> 3c515.c: In function `netdev_set_msglevel':
> 3c515.c:1626: error: `debug' undeclared (first use in this function)


Fixed.  Linus, please apply.

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 459 bytes --]

===== drivers/net/3c515.c 1.22 vs edited =====
--- 1.22/drivers/net/3c515.c	Tue Aug 26 16:42:22 2003
+++ edited/drivers/net/3c515.c	Tue Sep  2 13:44:18 2003
@@ -1590,12 +1590,12 @@
 
 static u32 netdev_get_msglevel(struct net_device *dev)
 {
-	return debug;
+	return corkscrew_debug;
 }
 
 static void netdev_set_msglevel(struct net_device *dev, u32 level)
 {
-	debug = level;
+	corkscrew_debug = level;
 }
 
 static struct ethtool_ops netdev_ethtool_ops = {

^ permalink raw reply	[flat|nested] 28+ messages in thread

* [patch] fix airo.c compile failure with gcc 2.95
  2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
@ 2003-09-03 15:56   ` Adrian Bunk
  2003-09-03 16:33     ` Jeff Garzik
  0 siblings, 1 reply; 28+ messages in thread
From: Adrian Bunk @ 2003-09-03 15:56 UTC (permalink / raw)
  To: Eyal Lebedinsky, Javier Achirica
  Cc: Marcelo Tosatti, lkml, linux-net, jgarzik

On Sun, Aug 31, 2003 at 09:11:47AM +1000, Eyal Lebedinsky wrote:
> Marcelo Tosatti wrote:
> > 
> > Hello,
> > 
> > Here goes -pre2. It contains an USB update, PPC merge, m68k merge, IDE
> 
> gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
> -Wstrict-pro
> totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> -fomit-frame-pointer
>  -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
> -DMODULE -DM
> ODVERSIONS -include
> /data2/usr/local/src/linux-2.4-pre/include/linux/modversions
> .h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=airo 
> -DEXPORT_SYMTAB -c ai
> ro.c
> airo.c: In function `airo_get_power':
> airo.c:5659: parse error before `int'
> airo.c:5660: `mode' undeclared (first use in this function)
> airo.c:5660: (Each undeclared identifier is reported only once
> airo.c:5660: for each function it appears in.)
> airo.c: In function `writerids':
> airo.c:6673: warning: unused variable `enabled'
> make[3]: *** [airo.o] Error 1
> make[3]: Leaving directory
> `/data2/usr/local/src/linux-2.4-pre/drivers/net/wirel
> ess'
> 
> Cannot tell if it is a bad merge ('int mode =' line should be earlier?)
> or bad programming (declaration must come first).

I assume you are using gcc 2.95?

The patch below fixes it for both 2.6 and 2.4.

I've tested the compilation with 2.6.0-test4-mm5 and gcc 2.95.

cu
Adrian

--- linux-2.6.0-test4-mm5-modular-no-smp/drivers/net/wireless/airo.c.old	2003-09-03 17:41:16.000000000 +0200
+++ linux-2.6.0-test4-mm5-modular-no-smp/drivers/net/wireless/airo.c	2003-09-03 17:41:45.000000000 +0200
@@ -5662,9 +5662,10 @@
 			  char *extra)
 {
 	struct airo_info *local = dev->priv;
+	int mode;
 
 	readConfigRid(local, 1);
-	int mode = local->config.powerSaveMode;
+	mode = local->config.powerSaveMode;
 	if ((vwrq->disabled = (mode == POWERSAVE_CAM)))
 		return 0;
 	if ((vwrq->flags & IW_POWER_TYPE) == IW_POWER_TIMEOUT) {

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [patch] fix airo.c compile failure with gcc 2.95
  2003-09-03 15:56   ` [patch] fix airo.c compile failure with gcc 2.95 Adrian Bunk
@ 2003-09-03 16:33     ` Jeff Garzik
  0 siblings, 0 replies; 28+ messages in thread
From: Jeff Garzik @ 2003-09-03 16:33 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Eyal Lebedinsky, Javier Achirica, Marcelo Tosatti, lkml, linux-net

thanks, applied


^ permalink raw reply	[flat|nested] 28+ messages in thread

* airo regression with Linux 2.4.23-pre2
  2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
                   ` (6 preceding siblings ...)
  2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
@ 2003-10-15 17:32 ` Udo A. Steinberg
  2003-10-15 19:47   ` Celso González
  7 siblings, 1 reply; 28+ messages in thread
From: Udo A. Steinberg @ 2003-10-15 17:32 UTC (permalink / raw)
  To: Javier Achirica; +Cc: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]


Hi,

My Cisco Aironet 350 Series PCMCIA network card does no longer work with the
latest 2.4 and 2.6 kernels. For 2.4.23 I have been able to identify the point
in time at which things broke. 2.4.23-pre1 still works and -pre2 does not.
The card is unable to acquire an IP address via DHCP and also doesn't seem to
receive any networking traffic at all with -pre2 and later.

Looking at the 2.4 changelog it seems that the following patch introduced
the problem.

MT> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
MT> ============================================
MT> <javier:tudela.mad.ttd.net>:
MT>   o [wireless airo] add support for MIC and latest firmwares

Do you have any idea what is going wrong here? If you need more information
to narrow down the problem, just ask.

Regards,
-Udo.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
@ 2003-10-15 19:47   ` Celso González
  2003-10-15 21:27     ` Javier Achirica
  0 siblings, 1 reply; 28+ messages in thread
From: Celso González @ 2003-10-15 19:47 UTC (permalink / raw)
  To: Udo A. Steinberg; +Cc: Javier Achirica, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Wed, Oct 15, 2003 at 07:32:02PM +0200, Udo A. Steinberg wrote:
> 
> Hi,
> 
> My Cisco Aironet 350 Series PCMCIA network card does no longer work with the
> latest 2.4 and 2.6 kernels. For 2.4.23 I have been able to identify the point
> in time at which things broke. 2.4.23-pre1 still works and -pre2 does not.
> The card is unable to acquire an IP address via DHCP and also doesn't seem to
> receive any networking traffic at all with -pre2 and later.
> 
> Looking at the 2.4 changelog it seems that the following patch introduced
> the problem.
> 
> MT> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> MT> ============================================
> MT> <javier:tudela.mad.ttd.net>:
> MT>   o [wireless airo] add support for MIC and latest firmwares
> 
> Do you have any idea what is going wrong here? If you need more information
> to narrow down the problem, just ask.

Same simptoms as me
Try removing this line on airo.c
Line 2948
ai->config._reserved1a[0] = 2 /* ??? */

It works for me

-- 
Celso



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-15 19:47   ` Celso González
@ 2003-10-15 21:27     ` Javier Achirica
  2003-10-16 13:51       ` Udo A. Steinberg
  2003-10-19 15:19       ` Joseph Pingenot
  0 siblings, 2 replies; 28+ messages in thread
From: Javier Achirica @ 2003-10-15 21:27 UTC (permalink / raw)
  To: Celso González
  Cc: Marc Giger, Udo A. Steinberg, Marcelo Tosatti, Jeff Garzik,
	Linux Kernel Mailing List


Hello,

I've been out for a few days, so I'm now catching up with e-mail...

Anyway, I've been discussing this issue with Celso and looks like the line
he mentions make his configuration fail. I added it because in other cases
it makes it work. Anyway, please test the driver removing that line and if
it fixes the problem I'll just try to figure out the exact cases when it's
neede (Cisco hasn't been very helpful about it)..

On Wed, 15 Oct 2003, Celso González wrote:

> On Wed, Oct 15, 2003 at 07:32:02PM +0200, Udo A. Steinberg wrote:
> >
> > Hi,
> >
> > My Cisco Aironet 350 Series PCMCIA network card does no longer work with the
> > latest 2.4 and 2.6 kernels. For 2.4.23 I have been able to identify the point
> > in time at which things broke. 2.4.23-pre1 still works and -pre2 does not.
> > The card is unable to acquire an IP address via DHCP and also doesn't seem to
> > receive any networking traffic at all with -pre2 and later.
> >
> > Looking at the 2.4 changelog it seems that the following patch introduced
> > the problem.
> >
> > MT> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> > MT> ============================================
> > MT> <javier:tudela.mad.ttd.net>:
> > MT>   o [wireless airo] add support for MIC and latest firmwares
> >
> > Do you have any idea what is going wrong here? If you need more information
> > to narrow down the problem, just ask.
>
> Same simptoms as me
> Try removing this line on airo.c
> Line 2948
> ai->config._reserved1a[0] = 2 /* ??? */
>
> It works for me
>
> --
> Celso
>
>
>




^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-15 21:27     ` Javier Achirica
@ 2003-10-16 13:51       ` Udo A. Steinberg
  2003-10-16 14:52         ` Marc Giger
  2003-10-19 15:19       ` Joseph Pingenot
  1 sibling, 1 reply; 28+ messages in thread
From: Udo A. Steinberg @ 2003-10-16 13:51 UTC (permalink / raw)
  To: Javier Achirica
  Cc: Celso González, Marc Giger, Marcelo Tosatti, Jeff Garzik,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

On Wed, 15 Oct 2003 23:27:35 +0200 (MEST) Javier Achirica (JA) wrote:

Hi,

JA> Anyway, I've been discussing this issue with Celso and looks like the line
JA> he mentions make his configuration fail. I added it because in other cases
JA> it makes it work. Anyway, please test the driver removing that line and if
JA> it fixes the problem I'll just try to figure out the exact cases when it's
JA> neede (Cisco hasn't been very helpful about it)..

JA> > Try removing this line on airo.c
JA> > Line 2948
JA> > ai->config._reserved1a[0] = 2 /* ??? */

Removing the line mentioned above fixes my problems as well. Thanks Celso.

-Udo.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-16 13:51       ` Udo A. Steinberg
@ 2003-10-16 14:52         ` Marc Giger
  0 siblings, 0 replies; 28+ messages in thread
From: Marc Giger @ 2003-10-16 14:52 UTC (permalink / raw)
  To: Udo A. Steinberg, Jean Tourrilhes
  Cc: Javier Achirica, Celso González, Marcelo Tosatti,
	Jeff Garzik, Linux Kernel Mailing List

> JA> > Try removing this line on airo.c
> JA> > Line 2948
> JA> > ai->config._reserved1a[0] = 2 /* ??? */
> 
> Removing the line mentioned above fixes my problems as well. Thanks
> Celso.

It fixes the problem by me too.

Marc

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-15 21:27     ` Javier Achirica
  2003-10-16 13:51       ` Udo A. Steinberg
@ 2003-10-19 15:19       ` Joseph Pingenot
  2003-10-20 10:33         ` Javier Achirica
  1 sibling, 1 reply; 28+ messages in thread
From: Joseph Pingenot @ 2003-10-19 15:19 UTC (permalink / raw)
  To: Javier Achirica; +Cc: linux-kernel

>From Javier Achirica on Wednesday, 15 October, 2003:
>Hello,
>I've been out for a few days, so I'm now catching up with e-mail...
>Anyway, I've been discussing this issue with Celso and looks like the line
>he mentions make his configuration fail. I added it because in other cases
>it makes it work. Anyway, please test the driver removing that line and if
>it fixes the problem I'll just try to figure out the exact cases when it's
>neede (Cisco hasn't been very helpful about it)..

Hello again.

I've tested the change, but I am having a problem even getting to that
  point.

When inserting the airo card in kernel 2.4.22 and 2.4.22-bk36, I get the
  following error:

Oct 18 16:50:10 paulus cardmgr[3036]: socket 1: 350 Series Wireless LAN Adapter
Oct 18 16:50:11 paulus airo: register interrupt 0 failed, rc -16
Oct 18 16:50:11 paulus airo_cs: RequestConfiguration: Operation succeeded
Oct 18 16:50:12 paulus cardmgr[3036]: get dev info on socket 1 failed: Resource temporarily unavailable

Do you know where this might be coming from?  The card works pretty well
  (it actually has the following problem in 2.4.21:


ct 19 00:20:52 paulus Warning: kfree_skb passed an skb still on a list (from c011a444).
Oct 19 00:20:52 paulus kernel BUG at skbuff.c:315!
Oct 19 00:20:52 paulus invalid operand: 0000
Oct 19 00:20:52 paulus CPU:    0
Oct 19 00:20:52 paulus EIP:    0010:[<c022dedb>]    Not tainted
Oct 19 00:20:52 paulus EFLAGS: 00010282
Oct 19 00:20:52 paulus eax: 00000045   ebx: c3c124a0   ecx: 00000001   edx: c9c5e000
Oct 19 00:20:52 paulus esi: c9f43f8c   edi: 00000000   ebp: c9f42000   esp: c9f43f78
Oct 19 00:20:52 paulus ds: 0018   es: 0018   ss: 0018
Oct 19 00:20:52 paulus Process keventd (pid: 2, stackpage=c9f43000)
Oct 19 00:20:52 paulus Stack: c02b6180 c011a444 c9f43f8c c011a444 c3c124a0 c89602e4 c89602e4 ffffffff 
Oct 19 00:20:52 paulus c9f42568 c0121fbc c02cd770 c9f42560 c9f42570 c9f42000 00000001 00000000 
Oct 19 00:20:52 paulus c02cb260 00010000 00000000 00000700 c0121ea0 c031f23c 00000000 c9f42000 
Oct 19 00:20:52 paulus Call Trace:    [<c011a444>] [<c011a444>] [<c0121fbc>] [<c0121ea0>] [<c0105000>]
Oct 19 00:20:52 paulus [<c0105706>] [<c0121ea0>]
Oct 19 00:20:52 paulus 
Oct 19 00:20:52 paulus Code: 0f 0b 3b 01 ac 53 2b c0 58 5a 8b 5c 24 08 e9 e2 fe ff ff 90 

(unfortunately, it doesn't look like ksymoops could translate this for
  some reason.)

which is what I was hoping was fixed in the upgrade.

Unfortunately, neither 2.4.22 work (as described above), and for some reason
  the pcmcia/cardbus driver locks up my system (I found this by stripping out
  everything and slowly adding stuff back 'till it broke) without an error
  that I can find in 2.6.0.  :(

Any assistance you can provide would be extremely helpful.  I can edit the
  files and add debugging info if need be--I just want to be able to use
  a current kernel again.  ;)

Thank you for your help.

-Joseph
-- 
Joseph===============================================trelane@digitasaru.net
"Asked by CollabNet CTO Brian Behlendorf whether Microsoft will enforce its
 patents against open source projects, Mundie replied, 'Yes, absolutely.'
 An audience member pointed out that many open source projects aren't
 funded and so can't afford legal representation to rival Microsoft's. 'Oh
 well,' said Mundie. 'Get your money, and let's go to court.' 
Microsoft's patents only defensive? http://swpat.ffii.org/players/microsoft

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: airo regression with Linux 2.4.23-pre2
  2003-10-19 15:19       ` Joseph Pingenot
@ 2003-10-20 10:33         ` Javier Achirica
  0 siblings, 0 replies; 28+ messages in thread
From: Javier Achirica @ 2003-10-20 10:33 UTC (permalink / raw)
  To: Joseph Pingenot; +Cc: linux-kernel



On Sun, 19 Oct 2003, Joseph Pingenot wrote:

> When inserting the airo card in kernel 2.4.22 and 2.4.22-bk36, I get the
>   following error:
>
> Oct 18 16:50:10 paulus cardmgr[3036]: socket 1: 350 Series Wireless LAN Adapter
> Oct 18 16:50:11 paulus airo: register interrupt 0 failed, rc -16
> Oct 18 16:50:11 paulus airo_cs: RequestConfiguration: Operation succeeded
> Oct 18 16:50:12 paulus cardmgr[3036]: get dev info on socket 1 failed: Resource temporarily unavailable
>
> Do you know where this might be coming from?  The card works pretty well
>   (it actually has the following problem in 2.4.21:

I had that problem with some versions of the ACPI PCI interrrupt routing
code. Disabling it fixes the bug.

> (unfortunately, it doesn't look like ksymoops could translate this for
>   some reason.)
>
> which is what I was hoping was fixed in the upgrade.

This bug is fixed (hopefully :-)

Javier Achirica


^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2003-10-20 11:12 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
2003-08-30 16:22 ` Dave Bentham
2003-08-30 19:35 ` system_lists
2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
2003-08-30 22:58   ` Marcelo Tosatti
2003-08-30 23:20     ` Norberto BENSA
2003-08-31  2:39       ` Marcelo Tosatti
2003-08-30 23:31     ` J.A. Magallon
2003-08-30 23:37     ` Alan Cox
2003-08-31  0:47       ` Jeff Garzik
2003-08-31  0:59         ` Kurt Wall
2003-08-31  3:03         ` Marcelo Tosatti
2003-09-01 19:14           ` Marcelo Tosatti
2003-08-30 23:01   ` Andre Tomt
2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
2003-09-03 15:56   ` [patch] fix airo.c compile failure with gcc 2.95 Adrian Bunk
2003-09-03 16:33     ` Jeff Garzik
2003-08-31  9:21 ` [PATCH] correct AT_PLATFORM for HT cpus J.A. Magallon
2003-09-02 15:18 ` [patch] 2.4.23-pre2: fix rocket.c compilation Adrian Bunk
2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
2003-09-02 17:47   ` [PATCH] " Jeff Garzik
2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
2003-10-15 19:47   ` Celso González
2003-10-15 21:27     ` Javier Achirica
2003-10-16 13:51       ` Udo A. Steinberg
2003-10-16 14:52         ` Marc Giger
2003-10-19 15:19       ` Joseph Pingenot
2003-10-20 10:33         ` Javier Achirica

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).