Re: tasklet_kill will always hang for recursive tasklets on a UP

From: kuznet@ms2.inr.ac.ru
To: nagendra_tomar@adaptec.com
Cc: wa@almesberger.net, quade@hsnr.de, linux-kernel@vger.kernel.org
Subject: Re: tasklet_kill will always hang for recursive tasklets on a UP
Date: Thu, 4 Sep 2003 17:25:36 +0400 (MSD)	[thread overview]
Message-ID: <200309041325.RAA15845@dub.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.44.0308282143330.14580-100000@localhost.localdomain> from "Nagendra Singh Tomar" at  =?ISO-8859-1?Q?=20=E1?= =?ISO-8859-1?Q?=D7=C7?= 28, 2003 09:55:33

Hello!

> All is fine, but the recursive tasklet problem is still there. We need 
> to add another state to tasklet TASKLET_STATE_KILLED which is set once 
> tasklet_kill is called. Once this is set tasklet_schedule just does not 
> schedule the tasklet.

Maybe. But all my past experience says me that it is some thing,
next to useless. Look, if you try to schedule some event not even caring
that the event handler is going to die, you do something really wrong.
State of death is connected not to tasklet but to source of events
which wake up the tasklet and need handling inside tasklet.
So, you just cannot tasklet_kill() before the source is shutdown and,
therefore, there are no good reasons to hold the bit inside the struct.

Alexey