linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew de Quincey <adq_dvb@lidskialf.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: torvalds@osdl.org, lkml <linux-kernel@vger.kernel.org>,
	acpi-devel@lists.sourceforge.net, linux-acpi@intel.com
Subject: [PATCH] 2.4.23-pre3 ACPI fixes series (3/3)
Date: Sat, 6 Sep 2003 01:15:52 +0100	[thread overview]
Message-ID: <200309060115.52967.adq_dvb@lidskialf.net> (raw)
In-Reply-To: <3F590E28.6090101@pobox.com>

This patch is actually a patch by "Jun Nakajima" <jun.nakajima@intel.com>
When setting an IRQ link device, it checks if the value returned by _CRS is 0. 
If so, it assumes everything went OK. This fixes problems on MANY VIA bioses.
It seems to be a standard-ish way of saying "the _CRS IRQ setting cannot be read".


--- linux-2.4.23-pre3.extirq/drivers/acpi/pci_link.c	2003-09-05 23:54:59.945755216 +0100
+++ linux-2.4.23-pre3.null_crs/drivers/acpi/pci_link.c	2003-09-05 23:57:39.782456344 +0100
@@ -277,6 +277,32 @@
 
 
 static int
+acpi_pci_link_try_get_current (
+	struct acpi_pci_link *link,
+	int irq)
+{
+	int result;
+
+	ACPI_FUNCTION_TRACE("acpi_pci_link_try_get_current");
+   
+	result = acpi_pci_link_get_current(link);
+	if (result && link->irq.active) 
+	{
+		return_VALUE(result);
+	}
+
+	if (!link->irq.active) 
+	{
+		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "No active IRQ resource found\n"));
+		printk(KERN_WARNING "_CRS returns NULL! Using IRQ %d for device (%s [%s]).\n", irq, acpi_device_name(link->device), acpi_device_bid(link->device));
+		link->irq.active = irq;
+	}
+   
+	return 0;
+}
+
+
+static int
 acpi_pci_link_set (
 	struct acpi_pci_link	*link,
 	int			irq)
@@ -382,7 +408,7 @@
 	}
 
 	/* Make sure the active IRQ is the one we requested. */
-	result = acpi_pci_link_get_current(link);
+	result = acpi_pci_link_try_get_current(link, irq);
 	if (result) {
 		return_VALUE(result);
 	}
@@ -600,10 +626,6 @@
 		else
 			printk(" %d", link->irq.possible[i]);
 	}
-	if (!link->irq.active)
-		printk(", disabled");
-	else if (!found)
-		printk(", enabled at IRQ %d", link->irq.active);
 	printk(")\n");
 
 	/* TBD: Acquire/release lock */


  parent reply	other threads:[~2003-09-05 23:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-05 18:58 [PATCH] Next round of ACPI IRQ fixes (VIA ACPI fixed) Andrew de Quincey
2003-09-05 21:35 ` Jeff Garzik
2003-09-05 23:16   ` [ACPI] " Andrew de Quincey
2003-09-05 22:28     ` Jeff Garzik
2003-09-05 22:28       ` Andrew Morton
2003-09-05 22:56         ` Randy.Dunlap
2003-09-06  0:15       ` [PATCH] 2.4.23-pre3 ACPI fixes series (1/3) Andrew de Quincey
2003-09-10 11:45         ` Bernhard Rosenkraenzer
2003-09-10 21:27           ` Andrew de Quincey
2003-09-10 15:31         ` Daniel Egger
2003-09-06  0:15       ` [PATCH] 2.4.23-pre3 ACPI fixes series (2/3) Andrew de Quincey
2003-09-06  0:15       ` Andrew de Quincey [this message]
2003-09-06  0:57       ` [PATCH] 2.6.0-test4 ACPI fixes series (1/4) Andrew de Quincey
2003-09-06  0:57       ` [PATCH] 2.6.0-test4 ACPI fixes series (2/4) Andrew de Quincey
2003-09-06  0:57       ` [PATCH] 2.6.0-test4 ACPI fixes series (3/4) Andrew de Quincey
2003-09-06  0:57       ` [PATCH] 2.6.0-test4 ACPI fixes series (4/4) Andrew de Quincey
2003-09-06  1:22         ` Jeff Garzik
2003-09-06 12:27           ` [ACPI] " Andrew de Quincey
2003-09-06 13:45             ` Andi Kleen
2003-09-08 19:46           ` Mikael Pettersson
2003-09-06 15:47         ` [ACPI] " Alan Cox
2003-09-07 14:54           ` Andrew de Quincey
2003-09-07 17:59             ` Alan Cox
2003-09-07 20:19               ` Andrew de Quincey
2003-09-06  0:02     ` [ACPI] Re: [PATCH] Next round of ACPI IRQ fixes (VIA ACPI fixed) Chris Wright
2003-09-06  1:21       ` Andrew de Quincey
2003-09-06  0:30         ` Jeff Garzik
2003-09-06  2:03           ` Chris Wright
2003-09-06 12:32             ` Andrew de Quincey
2003-09-11  1:36               ` Chris Wright
2003-09-06  1:27 [PATCH] 2.4.23-pre3 ACPI fixes series (3/3) Brown, Len

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200309060115.52967.adq_dvb@lidskialf.net \
    --to=adq_dvb@lidskialf.net \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).